Fixes issue #25 #26
Closed
Fixes issue #25 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a race! Thanks :) If this passes all the unit tests with PCRE < 7 I'll pull your change. |
|
Haha! No problems, might have helped not making an Issue and fixing it first >.< |
|
Did you get a chance to run the unit tests against it? The oldest PCRE version I have on any of my servers is 7.4... Also: PCRE 7.4 is dated 2007-09-21. When's the last time you updated your server? ;) |
|
I realise it's ancient, but as is the version of PHP available from the supported repos of CentOS 5.5. It's an environment I have to live with at the moment. When I run the tests I get: OK, but incomplete or skipped tests! |
|
Thanks, that works for me. Cherry-picked and hotfixed in 0.5.1. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hotfix adds PCRE < 7 compatibility.