Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the result of comparer.identical for a massive speedup #26

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

bobg
Copy link
Owner

@bobg bobg commented Jun 6, 2024

This PR adds a memoizing cache to the comparer type for the identical method, producing a sometimes enormous speedup.

Copy link

github-actions bot commented Jun 6, 2024

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires (at least) an increase in your module's patchlevel.

checking newComparer
  in results of func() *github.com/bobg/modver/v2.comparer
    old and new versions of github.com/bobg/modver/v2.comparer are not identical
      Patchlevel

@bobg bobg merged commit 16a7d9c into master Jun 6, 2024
1 check passed
@bobg bobg deleted the bobg/identicache branch June 6, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant