Add search wrap capability #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bobbylight Are you okay with implementing this? I can work at rebasing/redoing this & bobbylight/RSTAUI#14, but won't worry about it if it's not something you want to implement. |
|
I'm not deeply familiar with the code so if you wanted to just use my
commit as an example I'd be fine with that. It's been a long time since I
looked at it.
…On Tue, Jan 21, 2020 at 9:48 AM Paul Griffith ***@***.***> wrote:
@bobbylight <https://github.com/bobbylight> Are you okay with
implementing this? I can work at rebasing/redoing this &
bobbylight/RSTAUI#14 <bobbylight/RSTAUI#14>, but
won't worry about it if it's not something you want to implement.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#276?email_source=notifications&email_token=AAFW5CK3AEPYAMG3Y5QUKKLQ64YQFA5CNFSM4FTPDQSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJQUEBA#issuecomment-576799236>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW5CKGBSITSWUNRHXWWUTQ64YQFANCNFSM4FTPDQSA>
.
|
|
Thanks guys, I've been meaning to look at this PR but have been busy with mundane tasks like implementing proper Maven dependency support between all the RSTA projects. I'm happy for either of you to PR this. @paul-griffith I'll take a look at your most recent PR based off of @giles7777's. |
|
Closing since this PR was superseded by #329. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a SearchContext capability to wrap around the direction of searching. A separate pull request for the rsta project contains the user interface changes.