Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable merge queue #38

Merged
merged 13 commits into from
Sep 29, 2023
Merged

Enable merge queue #38

merged 13 commits into from
Sep 29, 2023

Conversation

jedel1043
Copy link
Member

As done in the main repo and the webpage repo.

@jedel1043 jedel1043 added the CI label Sep 20, 2023
@jedel1043 jedel1043 requested a review from a team September 20, 2023 15:16
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@raskad
Copy link
Member

raskad commented Sep 28, 2023

The cargo outdated action was failing because we had criterion in version 4 while there is version 5 available. Upgrading to version 5 requires that we increase the msrv to 1.60, since clap has that requirement.

@HalidOdat @jedel1043 do you think we should increase the msrv on this repository or rather keep the old version of criterion and remove the cargo outdated action? In this case I would say updating dependencies is not that important, since they are only dev-dependencies.

Edit: I see we already discussed this in #36 with the result of setting MSRV to 1.64. Since that was already agreed there I will do that here.

@HalidOdat HalidOdat added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 6138e7c Sep 29, 2023
@HalidOdat HalidOdat deleted the merge-queue branch October 5, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants