Add numeric separator lexing #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
==========================================
+ Coverage 59.97% 60.04% +0.07%
==========================================
Files 166 166
Lines 10851 10881 +30
==========================================
+ Hits 6508 6534 +26
- Misses 4343 4347 +4
Continue to review full report at Codecov.
|
HalidOdat
reviewed
Dec 26, 2020
| R: Read, | ||
| { | ||
| let mut prev_is_underscore = false; | ||
| let mut pos = cursor.pos(); |
There was a problem hiding this comment.
Do we need the pos variable, cant we call cursor.pos() where we need the position?
There was a problem hiding this comment.
This is to have the correct position when the separator is at the end of the number. If we take cursor.pos(), then the position is after the separator, on not on the separator.
boa/src/syntax/lexer/number.rs
Outdated
| cursor.take_while_ascii_pred(&mut buf, &|c: char| c.is_digit(kind.base()))?; | ||
| if cursor.peek()? == Some(b'_') { | ||
| return Err(Error::syntax( | ||
| "numeric separator not allowed after .", |
There was a problem hiding this comment.
Suggested change
| "numeric separator not allowed after .", | |
| "numeric separator not allowed after '.'", |
same here.
HalidOdat
added
enhancement
|
RageKnify
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #994
It changes the following: