-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build in master #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
bug
Something isn't working
test
Issues and PRs related to the tests.
labels
Dec 17, 2020
Test262 conformance changes:
|
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
=======================================
Coverage 59.56% 59.56%
=======================================
Files 166 166
Lines 10815 10815
=======================================
Hits 6442 6442
Misses 4373 4373
Continue to review full report at Codecov.
|
Benchmark for 44c17e8Click to view benchmark
|
This was referenced Dec 17, 2020
RageKnify
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the build in master is only partially failing, while it should be failing completely. We did not detect that adding
serde
as a required dependency would break the build.I have added it as mandatory, and we now control the deserialization / serialization of the output via the
deser
feature, which is a breaking change. This was required because we can't have a feature named as one of our dependencies if that dependency is not optional.I also took the opportunity to upgrade all dependencies and to update the test suite.
Let me know if you are happy with these changes :)