Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build in master #977

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Fixed build in master #977

merged 2 commits into from
Dec 18, 2020

Conversation

Razican
Copy link
Member

@Razican Razican commented Dec 17, 2020

It turns out that the build in master is only partially failing, while it should be failing completely. We did not detect that adding serde as a required dependency would break the build.

I have added it as mandatory, and we now control the deserialization / serialization of the output via the deser feature, which is a breaking change. This was required because we can't have a feature named as one of our dependencies if that dependency is not optional.

I also took the opportunity to upgrade all dependencies and to update the test suite.

Let me know if you are happy with these changes :)

@Razican Razican added bug Something isn't working test Issues and PRs related to the tests. labels Dec 17, 2020
@Razican Razican added this to the v0.11.0 milestone Dec 17, 2020
@github-actions
Copy link

Test262 conformance changes:

Test result master count PR count difference
Total 78,460 78,493 +33
Passed 19,388 19,392 +4
Ignored 15,559 15,585 +26
Failed 43,513 43,516 +3
Panics 447 447 0
Conformance 24.71 24.71 -0.01%

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #977 (44c17e8) into master (5c98676) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #977   +/-   ##
=======================================
  Coverage   59.56%   59.56%           
=======================================
  Files         166      166           
  Lines       10815    10815           
=======================================
  Hits         6442     6442           
  Misses       4373     4373           
Impacted Files Coverage Δ
boa/src/builtins/bigint/mod.rs 70.14% <ø> (ø)
boa/src/syntax/ast/constant.rs 48.00% <ø> (ø)
boa/src/syntax/ast/keyword.rs 47.42% <ø> (ø)
boa/src/syntax/ast/node/array/mod.rs 74.07% <ø> (ø)
boa/src/syntax/ast/node/await_expr/mod.rs 0.00% <ø> (ø)
boa/src/syntax/ast/node/block/mod.rs 56.66% <ø> (ø)
boa/src/syntax/ast/node/break_node/mod.rs 62.50% <ø> (ø)
boa/src/syntax/ast/node/call/mod.rs 84.21% <ø> (ø)
.../syntax/ast/node/conditional/conditional_op/mod.rs 63.63% <ø> (ø)
boa/src/syntax/ast/node/conditional/if_node/mod.rs 60.71% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c98676...034c9a0. Read the comment docs.

@github-actions
Copy link

Benchmark for 44c17e8

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 265.1±3.14ns N/A N/A
Arithmetic operations (Full) 178.4±2.04µs N/A N/A
Array access (Execution) 6.2±0.08µs N/A N/A
Array access (Full) 194.4±1.90µs N/A N/A
Array creation (Execution) 2.2±0.02ms N/A N/A
Array creation (Full) 2.2±0.02ms N/A N/A
Array pop (Execution) 812.8±7.55µs N/A N/A
Array pop (Full) 1105.7±12.04µs N/A N/A
Boolean Object Access (Execution) 3.6±0.05µs N/A N/A
Boolean Object Access (Full) 186.9±3.07µs N/A N/A
Clean js (Execution) 544.2±7.85µs N/A N/A
Clean js (Full) 760.5±8.94µs N/A N/A
Clean js (Parser) 27.2±0.20µs N/A N/A
Create Realm 359.5±5.52ns N/A N/A
Dynamic Object Property Access (Execution) 4.2±0.05µs N/A N/A
Dynamic Object Property Access (Full) 188.3±1.73µs N/A N/A
Expression (Parser) 5.0±0.05µs N/A N/A
Fibonacci (Execution) 636.4±6.71µs N/A N/A
Fibonacci (Full) 843.2±8.96µs N/A N/A
For loop (Execution) 16.9±0.26µs N/A N/A
For loop (Full) 206.1±1.98µs N/A N/A
For loop (Parser) 13.2±0.18µs N/A N/A
Goal Symbols (Parser) 8.8±0.07µs N/A N/A
Hello World (Parser) 2.4±0.02µs N/A N/A
Long file (Parser) 612.8±5.77ns N/A N/A
Mini js (Execution) 491.9±5.38µs N/A N/A
Mini js (Full) 687.5±10.02µs N/A N/A
Mini js (Parser) 24.0±0.31µs N/A N/A
Number Object Access (Execution) 2.9±0.04µs N/A N/A
Number Object Access (Full) 182.9±1.89µs N/A N/A
Object Creation (Execution) 3.7±0.04µs N/A N/A
Object Creation (Full) 187.1±1.99µs N/A N/A
RegExp (Execution) 7.1±0.08µs N/A N/A
RegExp (Full) 195.2±2.00µs N/A N/A
RegExp Literal (Execution) 8.1±0.10µs N/A N/A
RegExp Literal (Full) 194.6±1.87µs N/A N/A
RegExp Literal Creation (Execution) 7.1±0.10µs N/A N/A
RegExp Literal Creation (Full) 191.4±7.98µs N/A N/A
Static Object Property Access (Execution) 3.9±0.03µs N/A N/A
Static Object Property Access (Full) 187.5±1.55µs N/A N/A
String Object Access (Execution) 5.4±0.08µs N/A N/A
String Object Access (Full) 190.8±1.59µs N/A N/A
String comparison (Execution) 4.9±0.06µs N/A N/A
String comparison (Full) 191.2±1.30µs N/A N/A
String concatenation (Execution) 4.0±0.05µs N/A N/A
String concatenation (Full) 186.2±1.69µs N/A N/A
String copy (Execution) 3.1±0.04µs N/A N/A
String copy (Full) 182.0±2.12µs N/A N/A
Symbols (Execution) 2.7±0.03µs N/A N/A
Symbols (Full) 177.4±3.48µs N/A N/A

@Razican Razican merged commit b058b2d into master Dec 18, 2020
@Razican Razican deleted the fix_build branch December 18, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants