-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement String.prototype.codePointAt #935
Conversation
Codecov Report
@@ Coverage Diff @@
## master #935 +/- ##
==========================================
- Coverage 59.21% 59.20% -0.02%
==========================================
Files 166 166
Lines 10554 10563 +9
==========================================
+ Hits 6250 6254 +4
- Misses 4304 4309 +5
Continue to review full report at Codecov.
|
5838d85
to
9a826d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes look good, there was some nearby code that I was a bit confused by that I'd like another mantainer to check on.
ab07364
to
dbd0cdf
Compare
dbd0cdf
to
1dd0942
Compare
Just as a heads-up, I tried testing corner cases around unpaired surrogates until I realized that required this to be completed first: #736 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks good to me :)
This Pull Request fixes/closes #751.
It changes the following: