Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parser Expression] minor expression macro simplification #824

Merged
merged 3 commits into from
Oct 9, 2020
Merged

[parser Expression] minor expression macro simplification #824

merged 3 commits into from
Oct 9, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Oct 8, 2020

Removes one unnecessary parameter.

@codecov
Copy link

codecov bot commented Oct 8, 2020 •
edited
Loading

Codecov Report

Merging #824 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #824   +/-   ##
=======================================
  Coverage   59.23%   59.23%           
=======================================
  Files         157      157           
  Lines       10034    10034           
=======================================
  Hits         5944     5944           
  Misses       4090     4090
Impacted Files Coverage Δ
boa/src/syntax/parser/expression/mod.rs 78.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470dbb4...9a6b0ee. Read the comment docs.

@Razican Razican added this to the v0.11.0 milestone Oct 8, 2020
@Razican Razican added enhancement New feature or request parser Issues surrounding the parser labels Oct 8, 2020
Razican
Razican approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Razican Razican merged commit 456c2de into boa-dev:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

@Lan2u Lan2u Awaiting requested review from Lan2u

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
enhancement New feature or request parser Issues surrounding the parser
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@croraf @Razican @HalidOdat