Implement regress
#774
Merged
Implement regress
#774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TODO: Fix methods using capture groups - Hopefully everything still works with the refactor other than capture groups
Test: Improve string::tests::replace_with_function and fix minor typo Can be improved once ridiculousfish/regress#7 is closed
Match::groups simplifies some code.
- TODO: Fix methods using capture groups - Hopefully everything still works with the refactor other than capture groups
Test: Improve string::tests::replace_with_function and fix minor typo Can be improved once ridiculousfish/regress#7 is closed
Match::groups simplifies some code.
Codecov Report
@@ Coverage Diff @@
## master #774 +/- ##
==========================================
- Coverage 59.13% 59.10% -0.04%
==========================================
Files 155 155
Lines 9842 9837 -5
==========================================
- Hits 5820 5814 -6
- Misses 4022 4023 +1
Continue to review full report at Codecov.
|
HalidOdat
approved these changes
Oct 5, 2020
HalidOdat
added
builtins
Lan2u
approved these changes
Oct 5, 2020
|
It seems that this reduces our conformance for something like 19.01% to 18.99%. some of the issues I find are that things like this one fail: It seems that regress is not 100% spec compliant. We should check issues like this one and report them upstream. I will also add some comments, an invalid regex should never panic. |
Razican
reviewed
Oct 5, 2020
Razican
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #478.
It changes the following:
regresscrate in place of theregexcrate