-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the upstream version of the benchmark action #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RageKnify
approved these changes
Oct 2, 2020
HalidOdat
approved these changes
Oct 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
=======================================
Coverage 58.51% 58.51%
=======================================
Files 152 152
Lines 9476 9476
=======================================
Hits 5545 5545
Misses 3931 3931 Continue to review full report at Codecov.
|
Benchmark for a9eb96dClick to view benchmark
|
Benchmark for ab16e67Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some benchmarks are not showing properly in the graphs. This might be because we are not using the upstream version of the GitHub action, which includes some fixes. This could potentially fix that, and if it does, I can retroactivelly fix the benchmarks, since they need a re-adjustment anyways.