Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore tests from codecov count and disable annotations #724

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Disable codecov annotations in PR
  • Ignore tests when calculating coverage

@HalidOdat HalidOdat added the enhancement New feature or request label Sep 27, 2020
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #724 into master will decrease coverage by 13.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #724       +/-   ##
===========================================
- Coverage   71.79%   58.35%   -13.45%     
===========================================
  Files         199      156       -43     
  Lines       13943     9425     -4518     
===========================================
- Hits        10011     5500     -4511     
+ Misses       3932     3925        -7     
Impacted Files Coverage Δ
boa/src/syntax/ast/position.rs 86.20% <0.00%> (-10.41%) ⬇️
boa/src/environment/lexical_environment.rs 72.34% <0.00%> (-2.66%) ⬇️
boa/src/builtins/function/tests.rs
boa/src/property/attribute/tests.rs
boa/src/builtins/infinity/tests.rs
...a/src/syntax/parser/cursor/buffered_lexer/tests.rs
boa/src/syntax/parser/statement/if_stm/tests.rs
boa/src/exec/tests.rs
boa/src/syntax/parser/statement/break_stm/tests.rs
boa/src/builtins/map/tests.rs
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0348ba9...f5b1748. Read the comment docs.

@github-actions
Copy link

Benchmark for 12de04c

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 370.4±0.60ns 372.1±1.90ns -0.46%
Arithmetic operations (Full) 257.7±0.36µs 252.7±0.43µs +1.98%
Array access (Execution) 8.1±0.03µs 8.2±0.18µs -1.22%
Array access (Full) 271.9±0.38µs 270.2±0.25µs +0.63%
Array creation (Execution) 3.2±0.01ms 3.2±0.02ms 0.00%
Array creation (Full) 3.7±0.00ms 3.7±0.00ms 0.00%
Array pop (Execution) 1159.7±5.00µs 1162.4±5.73µs -0.23%
Array pop (Full) 1669.7±8.89µs 1670.8±2.83µs -0.07%
Boolean Object Access (Execution) 4.8±0.01µs 4.8±0.01µs 0.00%
Boolean Object Access (Full) 265.5±0.50µs 261.0±0.40µs +1.72%
Clean js (Execution) 729.4±3.55µs 732.1±3.43µs -0.37%
Clean js (Full) 1044.3±7.65µs 1040.2±10.45µs +0.39%
Clean js (Parser) 35.3±0.03µs 35.4±0.09µs -0.28%
Create Realm 467.9±0.49ns 466.5±0.27ns +0.30%
Dynamic Object Property Access (Execution) 5.4±0.02µs 5.3±0.03µs +1.89%
Dynamic Object Property Access (Full) 264.7±0.38µs 263.1±0.59µs +0.61%
Expression (Parser) 7.2±0.43µs 7.0±0.04µs +2.86%
Fibonacci (Execution) 793.0±2.90µs 795.2±2.34µs -0.28%
Fibonacci (Full) 1092.7±27.26µs 1081.2±2.02µs +1.06%
For loop (Execution) 22.3±0.12µs 22.3±0.20µs 0.00%
For loop (Full) 286.6±0.90µs 285.3±0.68µs +0.46%
For loop (Parser) 17.2±0.02µs 17.2±0.02µs 0.00%
Goal Symbols (Parser) 11.7±0.02µs 11.8±0.02µs -0.85%
Hello World (Parser) 3.0±0.00µs 3.0±0.02µs 0.00%
Long file (Parser) 755.7±1.60ns 770.2±0.55ns -1.88%
Mini js (Execution) 659.9±3.79µs 660.7±5.89µs -0.12%
Mini js (Full) 953.6±4.79µs 954.1±4.00µs -0.05%
Mini js (Parser) 31.2±0.03µs 31.1±0.09µs +0.32%
Number Object Access (Execution) 3.8±0.00µs 4.0±0.17µs -5.00%
Number Object Access (Full) 260.6±1.30µs 259.0±0.57µs +0.62%
Object Creation (Execution) 4.5±0.01µs 4.5±0.01µs 0.00%
Object Creation (Full) 264.7±0.55µs 264.0±0.79µs +0.27%
RegExp (Execution) 65.9±0.93µs 66.0±1.00µs -0.15%
RegExp (Full) 341.1±0.70µs 335.8±0.79µs +1.58%
RegExp Literal (Execution) 68.9±1.09µs 69.1±1.09µs -0.29%
RegExp Literal (Full) 340.0±0.60µs 336.2±1.04µs +1.13%
RegExp Literal Creation (Execution) 65.7±0.89µs 65.8±1.08µs -0.15%
RegExp Literal Creation (Full) 331.1±0.95µs 326.9±0.78µs +1.28%
Static Object Property Access (Execution) 4.8±0.01µs 4.8±0.01µs 0.00%
Static Object Property Access (Full) 262.0±1.26µs 261.3±2.50µs +0.27%
String Object Access (Execution) 7.0±0.02µs 7.1±0.02µs -1.41%
String Object Access (Full) 267.8±2.33µs 263.6±0.79µs +1.59%
String comparison (Execution) 6.3±0.02µs 6.2±0.02µs +1.61%
String comparison (Full) 278.8±13.17µs 267.8±0.50µs +4.11%
String concatenation (Execution) 5.1±0.01µs 5.1±0.01µs 0.00%
String concatenation (Full) 260.2±0.66µs 259.8±1.69µs +0.15%
String copy (Execution) 3.8±0.09µs 3.9±0.01µs -2.56%
String copy (Full) 259.0±0.56µs 256.8±3.94µs +0.86%
Symbols (Execution) 3.2±0.01µs 3.2±0.01µs 0.00%
Symbols (Full) 240.0±0.42µs 240.0±0.23µs 0.00%

@github-actions
Copy link

Benchmark for 656f5d1

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 363.5±13.99ns 352.2±17.82ns +3.21%
Arithmetic operations (Full) 258.3±14.56µs 257.5±15.42µs +0.31%
Array access (Execution) 8.8±0.77µs 8.6±0.78µs +2.33%
Array access (Full) 284.5±12.89µs 268.4±12.76µs +6.00%
Array creation (Execution) 3.2±0.07ms 3.1±0.08ms +3.23%
Array creation (Full) 3.4±0.09ms 3.3±0.16ms +3.03%
Array pop (Execution) 1082.9±55.37µs 1109.1±47.67µs -2.36%
Array pop (Full) 1586.2±84.95µs 1501.9±67.30µs +5.61%
Boolean Object Access (Execution) 4.9±0.20µs 4.9±0.21µs 0.00%
Boolean Object Access (Full) 271.4±9.78µs 255.9±23.50µs +6.06%
Clean js (Execution) 735.5±39.70µs 679.3±32.53µs +8.27%
Clean js (Full) 995.9±36.40µs 1020.7±75.43µs -2.43%
Clean js (Parser) 40.1±3.19µs 34.9±1.83µs +14.90%
Create Realm 483.8±29.93ns 538.6±60.21ns -10.17%
Dynamic Object Property Access (Execution) 5.6±0.33µs 5.6±0.35µs 0.00%
Dynamic Object Property Access (Full) 268.0±10.16µs 254.7±11.47µs +5.22%
Expression (Parser) 7.1±0.68µs 6.2±0.32µs +14.52%
Fibonacci (Execution) 934.4±62.32µs 924.5±78.43µs +1.07%
Fibonacci (Full) 1196.5±54.83µs 1116.7±46.06µs +7.15%
For loop (Execution) 23.6±1.50µs 24.6±2.02µs -4.07%
For loop (Full) 296.2±13.80µs 289.5±13.86µs +2.31%
For loop (Parser) 18.8±1.01µs 16.3±0.53µs +15.34%
Goal Symbols (Parser) 12.9±0.90µs 11.2±0.64µs +15.18%
Hello World (Parser) 3.2±0.12µs 2.9±0.17µs +10.34%
Long file (Parser) 858.8±59.39ns 736.7±45.39ns +16.57%
Mini js (Execution) 668.9±25.92µs 627.3±26.49µs +6.63%
Mini js (Full) 954.5±34.25µs 909.5±42.35µs +4.95%
Mini js (Parser) 37.0±5.80µs 29.9±1.28µs +23.75%
Number Object Access (Execution) 4.0±0.19µs 3.9±0.28µs +2.56%
Number Object Access (Full) 268.5±11.27µs 266.9±17.75µs +0.60%
Object Creation (Execution) 4.9±0.39µs 4.7±0.15µs +4.26%
Object Creation (Full) 269.2±9.36µs 258.8±13.19µs +4.02%
RegExp (Execution) 70.6±3.35µs 72.3±4.11µs -2.35%
RegExp (Full) 347.2±12.38µs 344.1±16.61µs +0.90%
RegExp Literal (Execution) 79.4±7.38µs 75.9±5.84µs +4.61%
RegExp Literal (Full) 351.3±12.46µs 346.0±17.98µs +1.53%
RegExp Literal Creation (Execution) 67.5±2.47µs 68.7±2.12µs -1.75%
RegExp Literal Creation (Full) 346.3±23.82µs 326.4±20.54µs +6.10%
Static Object Property Access (Execution) 5.0±0.24µs 5.0±0.24µs 0.00%
Static Object Property Access (Full) 272.0±9.13µs 253.8±12.66µs +7.17%
String Object Access (Execution) 7.1±0.44µs 7.0±0.40µs +1.43%
String Object Access (Full) 271.9±9.58µs 266.3±21.94µs +2.10%
String comparison (Execution) 6.7±0.69µs 6.9±0.50µs -2.90%
String comparison (Full) 272.5±13.64µs 264.5±13.03µs +3.02%
String concatenation (Execution) 5.7±0.66µs 5.3±0.26µs +7.55%
String concatenation (Full) 266.5±8.26µs 257.8±14.30µs +3.37%
String copy (Execution) 4.1±0.26µs 4.1±0.33µs 0.00%
String copy (Full) 259.9±9.50µs 255.5±16.88µs +1.72%
Symbols (Execution) 3.3±0.17µs 3.4±0.23µs -2.94%
Symbols (Full) 246.7±9.78µs 236.9±26.76µs +4.14%

@github-actions
Copy link

Benchmark for 46b88aa

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 308.2±21.09ns 310.4±17.06ns -0.71%
Arithmetic operations (Full) 217.5±15.19µs 226.1±13.08µs -3.80%
Array access (Execution) 7.3±0.49µs 7.2±0.43µs +1.39%
Array access (Full) 258.5±18.35µs 242.2±14.06µs +6.73%
Array creation (Execution) 2.6±0.14ms 2.6±0.16ms 0.00%
Array creation (Full) 2.9±0.23ms 2.9±0.24ms 0.00%
Array pop (Execution) 911.0±44.67µs 902.4±37.87µs +0.95%
Array pop (Full) 1293.7±94.66µs 1316.0±72.97µs -1.69%
Boolean Object Access (Execution) 4.6±0.41µs 4.1±0.27µs +12.20%
Boolean Object Access (Full) 230.9±11.57µs 236.4±17.15µs -2.33%
Clean js (Execution) 615.4±34.18µs 620.7±44.23µs -0.85%
Clean js (Full) 866.0±42.25µs 894.9±102.21µs -3.23%
Clean js (Parser) 32.0±1.86µs 31.0±2.24µs +3.23%
Create Realm 401.8±21.94ns 384.5±26.09ns +4.50%
Dynamic Object Property Access (Execution) 4.8±0.30µs 5.0±0.41µs -4.00%
Dynamic Object Property Access (Full) 239.3±17.32µs 237.7±15.87µs +0.67%
Expression (Parser) 5.5±0.33µs 5.5±0.36µs 0.00%
Fibonacci (Execution) 775.8±35.40µs 838.8±78.10µs -7.51%
Fibonacci (Full) 987.5±50.67µs 1014.3±57.25µs -2.64%
For loop (Execution) 19.5±1.20µs 20.0±1.30µs -2.50%
For loop (Full) 251.5±25.35µs 247.3±15.35µs +1.70%
For loop (Parser) 15.5±1.29µs 15.1±0.86µs +2.65%
Goal Symbols (Parser) 10.2±0.70µs 10.2±0.66µs 0.00%
Hello World (Parser) 2.6±0.17µs 2.6±0.17µs 0.00%
Long file (Parser) 664.7±73.40ns 656.3±37.09ns +1.28%
Mini js (Execution) 554.4±37.42µs 573.9±47.45µs -3.40%
Mini js (Full) 797.3±52.00µs 791.5±45.33µs +0.73%
Mini js (Parser) 28.1±2.27µs 27.2±1.56µs +3.31%
Number Object Access (Execution) 3.4±0.26µs 3.2±0.17µs +6.25%
Number Object Access (Full) 229.3±13.06µs 225.0±13.68µs +1.91%
Object Creation (Execution) 4.1±0.23µs 4.1±0.22µs 0.00%
Object Creation (Full) 235.9±14.00µs 235.2±18.14µs +0.30%
RegExp (Execution) 57.8±3.18µs 58.9±4.20µs -1.87%
RegExp (Full) 299.7±16.54µs 309.3±17.30µs -3.10%
RegExp Literal (Execution) 59.9±3.35µs 62.9±4.00µs -4.77%
RegExp Literal (Full) 294.7±14.68µs 301.0±17.02µs -2.09%
RegExp Literal Creation (Execution) 57.6±3.20µs 60.7±6.49µs -5.11%
RegExp Literal Creation (Full) 289.0±14.65µs 297.0±18.19µs -2.69%
Static Object Property Access (Execution) 4.2±0.22µs 4.5±0.29µs -6.67%
Static Object Property Access (Full) 240.7±20.15µs 233.7±23.21µs +3.00%
String Object Access (Execution) 6.0±0.37µs 6.0±0.37µs 0.00%
String Object Access (Full) 229.1±11.91µs 235.5±14.05µs -2.72%
String comparison (Execution) 5.5±0.39µs 5.5±0.30µs 0.00%
String comparison (Full) 232.1±12.38µs 237.5±13.27µs -2.27%
String concatenation (Execution) 4.6±0.27µs 4.5±0.25µs +2.22%
String concatenation (Full) 230.4±11.90µs 228.5±12.21µs +0.83%
String copy (Execution) 3.6±0.25µs 3.7±0.44µs -2.70%
String copy (Full) 222.1±12.95µs 225.7±15.77µs -1.60%
Symbols (Execution) 2.8±0.22µs 2.9±0.18µs -3.45%
Symbols (Full) 204.4±12.45µs 205.9±12.35µs -0.73%

@Lan2u
Copy link

Lan2u commented Sep 29, 2020

For my understanding - which tests aren't being included in coverage?

@jasonwilliams
Copy link
Member

I'm a bit confused by this, why is codecov including tests as code coverage by default?

@HalidOdat
Copy link
Member Author

For my understanding - which tests aren't being included in coverage?

Pretty much every test

--ignore-tests 'Ignore lines of test functions when collecting coverage'

I'm a bit confused by this, why is codecov including tests as code coverage by default?

This is what the owner of the repo says: xd009642/tarpaulin#351 (comment)

Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, I also find the annotations distracting

@HalidOdat HalidOdat added this to the v0.10.0 milestone Oct 2, 2020
@RageKnify RageKnify modified the milestones: v0.10.0, v0.11.0 Oct 2, 2020
@RageKnify RageKnify merged commit 45c5758 into master Oct 2, 2020
@RageKnify RageKnify deleted the better-codecov branch October 2, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants