-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Value::to_object to return GcObject #712
Conversation
Start work on boa-dev#577 Value::new_object_from_prototype becomes Object::new_object_from_prototype Introduce some small changes in other files to accommodate for the change in API, I assume once boa-dev#577 is finished everything will be cleaned up
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
==========================================
+ Coverage 71.69% 71.79% +0.10%
==========================================
Files 199 199
Lines 13865 13943 +78
==========================================
+ Hits 9941 10011 +70
- Misses 3924 3932 +8
Continue to review full report at Codecov.
|
There's one thing I started doubting after implementing, it may be more appropriate for the return type to be |
You mean let object = Object::with_prototype(Value::null(), ...); |
Suggestions made in boa-dev#712
This Pull Request starts the work on #577.
It changes the following:
Value::to_object
now returnsResult<GcObject>
rather thanResult<Value>
Value::new_object_from_prototype
toObject::new_object_from_prototype
I assume those minor changes will be cleaned up once the separation of the
Object
andValue
API is complete.