-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CLEAN_JS and MINI_JS benches #581
Conversation
These benches are arbitrary code which is subject to change, functionally the programs are identical.
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
==========================================
+ Coverage 71.25% 72.56% +1.30%
==========================================
Files 176 179 +3
Lines 11557 13259 +1702
==========================================
+ Hits 8235 9621 +1386
- Misses 3322 3638 +316
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this really go in exec? this to me seems like we are benchmarking the lexer/parser and not execution.
What do you think? @Razican @jasonwilliams
If I'm not mistaken, the part inside of the |
I can implement this in the same PR, if this is wanted? |
Yes, please, if you can, that would be more complete :) |
Added identical benchmark cases for parser.
I think this is blocked until #640 lands, since it will need a refactor. |
#640 is now merged so this is unblocked :) |
Adding js scripts in bench_scripts & moving exec, full and parser benchmarks to new include_str!() macro.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good from my side, but let's wait for #646 to land in order to not fail the tests.
* Added CLEAN_JS and MINI_JS benches (#581) * Added CLEAN_JS and MINI_JS benches These benches are arbitrary code which is subject to change, functionally the programs are identical. * Forgot semicolon * Adding parsing benchmarks for CleanJS & MiniJS Added identical benchmark cases for parser. * Migrating Clean and Mini benchmarks to new format Adding js scripts in bench_scripts & moving exec, full and parser benchmarks to new include_str!() macro. * Move `require_object_coercible` to `Value` (#654) Co-authored-by: neeldug <[email protected]> Co-authored-by: HalidOdat <[email protected]>
These benches are arbitrary code which is subject to change,
functionally the programs are identical.
This Pull Request fixes/closes #564 .
It changes the following:
Specifically went for slightly longer function for visible change when minifying code with whitespace and character savings.