Value refactor
#498
Merged
Value refactor
#498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
performance
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 67.88% 68.06% +0.18%
==========================================
Files 165 169 +4
Lines 9932 9918 -14
==========================================
+ Hits 6742 6751 +9
+ Misses 3190 3167 -23
Continue to review full report at Codecov.
|
Benchmark for 20b71c0Click to view benchmark
|
|
Woww. The benchmarks are awesome. I did not expect that big of an improvement from an initial refactor of |
|
Apparently |
HalidOdat
force-pushed
the
refactor/value
branch
from
a2b8600
to
935ac2a
Compare
Benchmark for 0813346Click to view benchmark
|
Benchmark for b160799Click to view benchmark
|
Benchmark for 9f00b7cClick to view benchmark
|
|
Size of |
HalidOdat
force-pushed
the
refactor/value
branch
from
fd7ceff
to
fc1a8d8
Compare
Benchmark for de07dc4Click to view benchmark
|
Benchmark for d5b34c3Click to view benchmark
|
HalidOdat
force-pushed
the
refactor/value
branch
from
a3b996d
to
2ef288a
Compare
HalidOdat
force-pushed
the
refactor/value
branch
from
15f6b21
to
1d179d5
Compare
Benchmark for 5dff5c7Click to view benchmark
|
Benchmark for f7daf82Click to view benchmark
|
Benchmark for aab0800Click to view benchmark
|
|
This is ready for review :) @Razican @jasonwilliams |
HalidOdat
force-pushed
the
refactor/value
branch
from
c035f1a
to
d5025e2
Compare
Benchmark for 62c19c0Click to view benchmark
|
HalidOdat
force-pushed
the
refactor/value
branch
from
d5025e2
to
02e8ce4
Compare
Benchmark for aebb26eClick to view benchmark
|
|
I did a profile of The profile for |
| @@ -28,7 +28,7 @@ use gc::{unsafe_empty_trace, Finalize, Trace}; | |||
| use std::fmt::{self, Debug}; | |||
|
|
|||
| /// _fn(this, arguments, ctx) -> ResultValue_ - The signature of a built-in function | |||
| pub type NativeFunctionData = fn(&mut Value, &[Value], &mut Interpreter) -> ResultValue; | |||
| pub type NativeFunctionData = fn(&Value, &[Value], &mut Interpreter) -> ResultValue; | |||
There was a problem hiding this comment.
Whats the reason behind the change here?
There was a problem hiding this comment.
Whats the reason behind the change here?
It's because the Value does not need to be mutable itself, except Object and Object is covered in a GcCell<...> it has interior mutability, so we can borrow_mut the Object with a immutable reference to Value.
This eliminated some places where we were awkwardly cloning the value and passing it to a function because the builtin function required it (&mut value.clone()), instead of just passing the value direclty.
Razican
approved these changes
Jun 22, 2020
Benchmark for 6de3aecClick to view benchmark
|
- Refactor `String` => `Rc<str>` - Refactor `Symbol` => `Rc<Symbol>` - Refactor `BigInt` => `RcBigInt` - Changed function signature, from `&mut Value` to `&Value` - Removed `Interpreter::value_to_rust_number() - Abstracted `Gc<GcCell<Object>>` to `GcObject` - Removed unnecessary `Box`s in global environment - Extracted `extensible` from internal slots - Made `to_primitive` throw errors - Removed `strict` parameter in `SameValue` function. - The `SameValue` function is not dependent on strict mode.
HalidOdat
force-pushed
the
refactor/value
branch
from
765e0ae
to
ca0fa50
Compare
Benchmark for f951c8fClick to view benchmark
|
|
Lets merge this :) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #465
It changes the following:
Gc<...>=>Value::Object(Gc<GcCell<Object>>)ValueData=>ValueRcString,RcSymbol,RcBigIntValue::String(String)=>Value::String(RcString)Value::Symbol(Symbol)=>Value::Symbol(RcSymbol)Value::BigInt(BigInt)=>Value::BigInt(RcBigInt)Gc<GcCell<Object>>=>GcObjectValuesize from40bytes =>24bytesthis, from&mut Value=>&ValueInterpreter::value_to_rust_number()Boxs in global environmentextensibleforinternal_slotsto_primitive,ordinary_to_primitiveandValue::equalsthrow errors.strictparameter ofSameValue(it is not dependent on strict mode)