Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add From<Cow<'a, str>> for JsString #4134

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

CrazyboyQCD
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.75%. Comparing base (6ddc2b4) to head (ff55474).
Report is 344 commits behind head on main.

Files with missing lines Patch % Lines
core/string/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4134      +/-   ##
==========================================
+ Coverage   47.24%   53.75%   +6.51%     
==========================================
  Files         476      485       +9     
  Lines       46892    48460    +1568     
==========================================
+ Hits        22154    26050    +3896     
+ Misses      24738    22410    -2328     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@jedel1043 jedel1043 requested a review from a team January 15, 2025 02:49
@jedel1043 jedel1043 added enhancement New feature or request Internal Category for changelog labels Jan 15, 2025
@jedel1043 jedel1043 added this to the next-release milestone Jan 15, 2025
@jedel1043 jedel1043 added this pull request to the merge queue Jan 15, 2025
Merged via the queue into boa-dev:main with commit c48056e Jan 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants