Use cow_to_ascii_uppercase instead
#4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heygsc
changed the title
cow_to_ascii_lowercase insteadcow_to_ascii_uppercase instead
hansl
approved these changes
Jan 13, 2025
|
Good work! Approved. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4124 +/- ##
==========================================
+ Coverage 47.24% 53.79% +6.55%
==========================================
Files 476 485 +9
Lines 46892 48396 +1504
==========================================
+ Hits 22154 26037 +3883
+ Misses 24738 22359 -2379 ☔ View full report in Codecov by Sentry. |
jedel1043
requested changes
Jan 13, 2025
Co-authored-by: José Julián Espina <[email protected]>
Okay, I've made the changes. |
jedel1043
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is part of #4123.
https://rust-lang.github.io/rust-clippy/master/index.html#disallowed_methods
If this PR can be merged, I will continue to use more cow methods in clippy.