Revamp JobQueue into JobExecutor and introduce NativeAsyncJob
#4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
|
hansl
requested changes
Jan 10, 2025
jedel1043
changed the title
NativeAsyncJobNativeAsyncJob and revamp JobQueue to `JobExecutor
jedel1043
changed the title
NativeAsyncJob and revamp JobQueue to `JobExecutorJobQueue into JobExecutor and introduce NativeAsyncJob
jedel1043
force-pushed
the
native-async-job
branch
from
c123722 to
a1bcc77
Compare
| /// The [`Future`] job returned by a [`NativeAsyncJob`] operation. | ||
| pub type BoxedFuture<'a> = Pin<Box<dyn Future<Output = JsResult<JsValue>> + 'a>>; | ||
|
|
||
| /// An ECMAScript [Job] that can be run asynchronously. |
There was a problem hiding this comment.
Are there any scenarios where these are not ran asynchronously?
There was a problem hiding this comment.
Yeah, an implementor can decide to block on each future if they want to.
jasonwilliams
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
LGTM
Nice work, I think the examples look good and would do well with some discoverability. I've created an issue to improve it
hansl
approved these changes
Jan 12, 2025
jedel1043
force-pushed
the
native-async-job
branch
from
a1bcc77 to
5dd1972
Compare
jedel1043
force-pushed
the
native-async-job
branch
from
5dd1972 to
9c35fcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the API of
JobQueueto take a non_exhaustive enumJob, which should avoid breaking changes in the future. Some other changes:JobQueuetoJobExecutor.JobPromise, which is a wrapper aroundNativeJobbut clearly states that the job will push promises forward.NativeAsyncJob, an equivalent toNativeJobthat isFuture-compatible.