-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WPT as optional tests for boa_runtime #4008
Open
hansl
wants to merge
20
commits into
boa-dev:main
Choose a base branch
from
hansl:wpt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7585a8d
Add a URL class (with caveats)
hansl 2255831
Adding tests and using url::quirks for simpler getters/setters
hansl dd551d1
clippies
hansl c445a06
Add WPT as optional tests for boa_runtime
hansl 08b64fb
Rebuilding Cargo.toml
hansl c17f3a6
clippies
hansl e38130f
Merge remote-tracking branch 'origin/runtime-url-class' into wpt
hansl 11a283a
clippies and cleanup
hansl f435931
disable clippy on rstest which would fail without the right env var
hansl 6c0abbc
Move to a release of rstest that has la10736/rstest#277 merged
hansl 9e9a37c
Load UTF16 files and move to using latest URL
hansl 3f2f19a
Remove code in comment
hansl 4abea06
Merge branch 'main' into wpt
hansl 23b6b1b
fix some compiler warnings
hansl d68a460
clippies
hansl cf02e79
Merge remote-tracking branch 'upstream/main' into wpt
hansl 4062561
Merge remote-tracking branch 'upstream/main' into wpt
hansl 4d88940
Move WPT tests to their own crate
hansl b113e76
Exclude the WPT tests from the default members
hansl 19adf0d
Merge remote-tracking branch 'upstream/main' into wpt
hansl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I think it's slightly weird to have tests be enabled by features instead of by only the
test
cfg. Can we just have a separate crate in the workspace for wpt tests, just likeboa_tester
? We could also potentially merge them together in the future.