Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gc threshold #3908

Merged
merged 4 commits into from
Jul 9, 2024
Merged

bump gc threshold #3908

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
706501b
bump gc threshold
jasonwilliams Jul 9, 2024
e13eaa8
add comment for threshold
jasonwilliams Jul 9, 2024
ba43edb
cmoments
jasonwilliams Jul 9, 2024
438838e
make number 2^20 for better alignment
jasonwilliams Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion core/gc/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ thread_local!(static BOA_GC: RefCell<BoaGc> = RefCell::new( BoaGc {

#[derive(Debug, Clone, Copy)]
struct GcConfig {
/// The threshold at which the garbage collector will trigger a collection.
threshold: usize,
/// The percentage of used space at which the garbage collector will trigger a collection.
used_space_percentage: usize,
}

Expand All @@ -63,7 +65,8 @@ struct GcConfig {
impl Default for GcConfig {
fn default() -> Self {
Self {
threshold: 1024,
// Start at 1MB, the nursary size for V8 is ~1-8MB and SM can be up to 16MB
threshold: 1_048_576,
used_space_percentage: 70,
}
}
Expand Down Expand Up @@ -191,6 +194,8 @@ impl Allocator {
if gc.runtime.bytes_allocated > gc.config.threshold {
Collector::collect(gc);

// Post collection check
// If the allocated bytes are still above the threshold, increase the threshold.
if gc.runtime.bytes_allocated
> gc.config.threshold / 100 * gc.config.used_space_percentage
{
Expand Down
Loading