Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_unchecked method to JsString and JsStr #3898

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Add get_unchecked method to JsString and JsStr #3898

merged 3 commits into from
Jul 9, 2024

Conversation

CrazyboyQCD
Copy link
Contributor

This adds get_unchecked method to JsString and JsStr for future possible optimization usage.

@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 51.52%. Comparing base (6ddc2b4) to head (dfc5cf7).
Report is 201 commits behind head on main.

Files Patch % Lines
core/string/src/str.rs 0.00% 24 Missing ⚠️
core/string/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3898      +/-   ##
==========================================
+ Coverage   47.24%   51.52%   +4.27%     
==========================================
  Files         476      467       -9     
  Lines       46892    44724    -2168     
==========================================
+ Hits        22154    23042     +888     
+ Misses      24738    21682    -3056

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jedel1043
jedel1043 reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation wise looks perfect! I just have a styling nitpick and a doc suggestion.

core/string/src/str.rs Outdated Show resolved Hide resolved
core/string/src/str.rs Show resolved Hide resolved
jedel1043
jedel1043 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your contribution!

HalidOdat
HalidOdat approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat added this pull request to the merge queue Jul 9, 2024
Merged via the queue into boa-dev:main with commit 6bc78bf Jul 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CrazyboyQCD @HalidOdat @jedel1043