Refactor call frame access to avoid panic checks #3888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly changes how we store and access call frames in the vm. In addition to the
frames
stack, there is now aframe
field that always holds the current call frame. The main reason for this is, so that we can avoid panic checks in critical paths.I also removed some duplicate calls to
Vm::frame
andVm::fram_mut
and grouped them where possible. This should not be that relevant anymore, since now it's just a field access.Here two graphs to visualize the change. These are running in
dev
profile so functions are visible. Here the bigger impact seems to actually be the deref of theframes
vec, but I'm not sure if the actual cost inrelease
looks different.Before:
After:
And here some benchmarks. I did not run them multiple times, the impact seems a bit high to me:
Before:
After: