Combine HasProperty
and Get
operations when possible
#3883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new object operation that combines the
HasProperty
andGet
operations.In some cases in the spec
HasProperty
andGet
are called on an object, with the same arguments, directly following each other. Both operations boil down to (in most cases)[[GetOwnProperty]]
, just thatHasProperty
does not return the value. To avoid duplicating the exact same operations we can combine both operations.I have some Flame Graphs from a
GetName
operation to visualize the benefit:Before:
After:
I also ran the benchmarks:
Before:
After: