Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FormalParameterList from CodeBlock #3882

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

HalidOdat
Copy link
Member

This is a simple change that removes the formal parameter list from codeblock which was only needed in non-strict mode and compute the required binding indices when needed during compilation, instead of every function call. This also reduces the CodeBlock size by 16 bytes.

@HalidOdat HalidOdat added execution Issues or PRs related to code execution Internal Category for changelog labels Jun 27, 2024
Copy link

github-actions bot commented Jun 27, 2024

Test262 conformance changes

Test result main count PR count difference
Total 50,213 50,213 0
Passed 42,981 42,981 0
Ignored 1,411 1,411 0
Failed 5,821 5,821 0
Panics 0 0 0
Conformance 85.60% 85.60% 0.00%

It is not used in strict mode and in non-strict mode it's only used to
construct the binding indices for the `MappedArguments`.
@HalidOdat HalidOdat force-pushed the remove-formal-parameters-from-code-block branch from ee719d3 to e6cd4cb Compare June 27, 2024 18:37
@raskad raskad requested a review from a team June 29, 2024 01:55
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization!

@jedel1043 jedel1043 added this pull request to the merge queue Jun 29, 2024
Merged via the queue into main with commit 2d91cd1 Jun 29, 2024
13 checks passed
@jedel1043 jedel1043 deleted the remove-formal-parameters-from-code-block branch June 29, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants