Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump temporal_rs to latest commit #3880

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Bump temporal_rs to latest commit #3880

merged 6 commits into from
Jun 25, 2024

Conversation

jedel1043
Copy link
Member

Will have to publish a new version for temporal_rs before publishing 0.19, but this at least integrates with the new features.

@jedel1043 jedel1043 added dependencies Pull requests that update a dependency file Internal Category for changelog labels Jun 24, 2024
@jedel1043 jedel1043 added this to the v0.18.1 milestone Jun 24, 2024
@jedel1043 jedel1043 requested a review from a team June 24, 2024 06:24
Copy link

github-actions bot commented Jun 24, 2024

Test262 conformance changes

Test result main count PR count difference
Total 50,771 50,213 -558
Passed 43,015 42,981 -34
Ignored 1,411 1,411 0
Failed 6,345 5,821 -524
Panics 19 0 -19
Conformance 84.72% 85.60% +0.87%
Fixed tests (1):
test/built-ins/Temporal/PlainTime/prototype/add/argument-string-negative-fractional-units.js (previously Failed)
Fixed panics (19):
test/built-ins/Temporal/Duration/prototype/round/smallestunit-plurals-accepted-string.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/largestunit-wrong-type.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/roundingincrement-wrong-type.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/round-negative-result.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/subclassing-ignored.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/roundingincrement-undefined.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/smallestunit-wrong-type.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-undefined.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/smallestunit-string-shorthand-string.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/largestunit-smallestunit-combinations.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/relativeto-number.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/order-of-operations.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/largestunit-undefined.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/smallestunit-undefined.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/round-cross-unit-boundary.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/balance-subseconds.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/balance-negative-result.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/relativeto-undefined-throw-on-calendar-units.js (previously Panic)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-wrong-type.js (previously Panic)

@jedel1043
Copy link
Member Author

jedel1043 commented Jun 24, 2024

Checked the tests and they're a regression from temporal_rs. Will try to patch it there.
(boa-dev/temporal#57)

@jedel1043 jedel1043 marked this pull request as draft June 24, 2024 08:30
jedel1043 added a commit to boa-dev/temporal that referenced this pull request Jun 24, 2024
@jedel1043 jedel1043 marked this pull request as ready for review June 25, 2024 19:08
@jedel1043 jedel1043 requested a review from a team June 25, 2024 19:09
@raskad raskad added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 2458d73 Jun 25, 2024
13 checks passed
@jedel1043 jedel1043 deleted the bump_temporal_rs branch June 25, 2024 19:47
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants