Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace js_str with js_string in examples #3836

Merged
merged 1 commit into from
May 3, 2024
Merged

Replace js_str with js_string in examples #3836

merged 1 commit into from
May 3, 2024

Conversation

getong
Copy link
Contributor

@getong getong commented May 1, 2024 •
edited by HalidOdat
Loading

It changes the following:

  • replace js_str with js_string in the example code

@getong getong force-pushed the replace-js-str branch from dfb0b14 to e031ff8 Compare May 1, 2024 21:39
@codecov Codecov
Copy link

codecov bot commented May 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.76%. Comparing base (6ddc2b4) to head (bbb230f).
Report is 154 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3836      +/-   ##
==========================================
+ Coverage   47.24%   50.76%   +3.52%     
==========================================
  Files         476      466      -10     
  Lines       46892    45283    -1609     
==========================================
+ Hits        22154    22989     +835     
+ Misses      24738    22294    -2444

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getong getong force-pushed the replace-js-str branch from e031ff8 to b2bc244 Compare May 2, 2024 03:27
@HalidOdat
Copy link
Member

HalidOdat commented May 2, 2024 •
edited
Loading

The js_str is deprecated

What is meant by this? js_str just landed on main yesterday...

EDIT: BTW I'm fine with replacing them with js_string since they are converted to JsString immediately in the examples.

@getong
Copy link
Contributor Author

getong commented May 2, 2024

The js_str is deprecated

What is meant by this? js_str just landed on main yesterday...

EDIT: BTW I'm fine with replacing them with js_string since they are converted to JsString immediately in the examples.

Sorry for the info, just replace js_str with js_string

@getong getong force-pushed the replace-js-str branch from b2bc244 to 266bc01 Compare May 3, 2024 15:31
@getong
Copy link
Contributor Author

getong commented May 3, 2024

rebase to main branch, which fix clippy warning

@getong getong force-pushed the replace-js-str branch from 266bc01 to bbb230f Compare May 3, 2024 16:52
@getong
Copy link
Contributor Author

getong commented May 3, 2024

getong#1
All the test have passed

jedel1043
jedel1043 approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@HalidOdat HalidOdat changed the title replace js_str with js_string Replace js_str with js_string in examples May 3, 2024
@HalidOdat HalidOdat added the Internal Category for changelog label May 3, 2024
@HalidOdat HalidOdat added this to the v0.18.1 milestone May 3, 2024
@HalidOdat HalidOdat added this pull request to the merge queue May 3, 2024
Merged via the queue into boa-dev:main with commit 12adec5 May 3, 2024
14 checks passed
@getong getong deleted the replace-js-str branch May 3, 2024 23:06
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
Internal Category for changelog
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@getong @HalidOdat @jedel1043 @raskad