Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of ToString call in Function constructor #3820

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix order of ToString call in Function constructor #3820

merged 1 commit into from
Apr 18, 2024

Conversation

HalidOdat
Copy link
Member

The ToString method was being called on the body before the paramater list, this caused some test262 tests to fail.

@HalidOdat
Fix order of ToString call in Function constructor
9f78b3f 
The `ToString` method was being called on the body before the paramater
list, this caused some test262 tests to fail.
@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Apr 18, 2024
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,731 50,731 0
Passed 42,971 42,973 +2
Ignored 1,395 1,395 0
Failed 6,365 6,363 -2
Panics 18 18 0
Conformance 84.70% 84.71% +0.00%
Fixed tests (2): 
test/built-ins/Function/S15.3.2.1_A3_T1.js (previously Failed)
test/built-ins/Function/S15.3.2.1_A3_T3.js (previously Failed)

@HalidOdat HalidOdat marked this pull request as ready for review April 18, 2024 13:39
@HalidOdat HalidOdat requested a review from a team April 18, 2024 13:39
@HalidOdat HalidOdat added this to the v0.18.1 milestone Apr 18, 2024
@nekevss nekevss requested a review from a team April 18, 2024 13:55
jedel1043
jedel1043 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jedel1043 jedel1043 added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit 261e264 Apr 18, 2024
13 checks passed
@raskad raskad deleted the fix/function-constructor-order-of-to-string branch May 11, 2024 20:29
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HalidOdat @jedel1043 @nekevss @raskad