-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to create modules from a JSON value #3804
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3804 +/- ##
==========================================
+ Coverage 47.24% 50.28% +3.04%
==========================================
Files 476 459 -17
Lines 46892 44966 -1926
==========================================
+ Hits 22154 22612 +458
+ Misses 24738 22354 -2384 ☔ View full report in Codecov by Sentry. |
I really think those functions should be static methods of |
I don't mind that, let me make that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me!
No description provided.