Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to create modules from a JSON value #3804

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Apr 10, 2024

No description provided.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.28%. Comparing base (6ddc2b4) to head (c13dddf).
Report is 130 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3804      +/-   ##
==========================================
+ Coverage   47.24%   50.28%   +3.04%     
==========================================
  Files         476      459      -17     
  Lines       46892    44966    -1926     
==========================================
+ Hits        22154    22612     +458     
+ Misses      24738    22354    -2384     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043
Copy link
Member

jedel1043 commented Apr 10, 2024

I really think those functions should be static methods of Module instead, possibly following the steps of ParseJSONModule to be spec-compliant. A Module::json(JsString) -> JsResult<Module> function should be able to cover almost all usages.

@hansl
Copy link
Contributor Author

hansl commented Apr 10, 2024

I don't mind that, let me make that change.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me!

@jedel1043 jedel1043 requested a review from a team April 11, 2024 20:45
@jedel1043 jedel1043 added enhancement New feature or request API labels Apr 11, 2024
@jedel1043 jedel1043 added this to the v0.18.1 milestone Apr 11, 2024
@nekevss nekevss added this pull request to the merge queue Apr 12, 2024
Merged via the queue into boa-dev:main with commit d915c9b Apr 12, 2024
14 checks passed
@raskad raskad modified the milestones: v0.18.1, v0.19.0 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants