-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an embed_module!() macro to boa_interop #3784
Conversation
The macro creates a ModuleLoader that includes all JS files from a directory.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3784 +/- ##
==========================================
+ Coverage 47.24% 50.26% +3.01%
==========================================
Files 476 461 -15
Lines 46892 45058 -1834
==========================================
+ Hits 22154 22647 +493
+ Misses 24738 22411 -2327 ☔ View full report in Codecov by Sentry. |
@jedel1043 this would be ready for review. My use case for this is to have a build process which uses parcel, then embedding the resulting dist folder in the executable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs to appease clippy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
The macro creates a ModuleLoader that includes all JS files from a directory.