-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't run test262 on push #3774
Merged
jasonwilliams
merged 6 commits into
boa-dev:main
from
jasonwilliams:remove-test262-push
Mar 31, 2024
Merged
don't run test262 on push #3774
jasonwilliams
merged 6 commits into
boa-dev:main
from
jasonwilliams:remove-test262-push
Mar 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwilliams
added
github_actions
Pull requests that update Github_actions code
Internal
Category for changelog
labels
Mar 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3774 +/- ##
==========================================
+ Coverage 47.24% 47.73% +0.48%
==========================================
Files 476 454 -22
Lines 46892 44747 -2145
==========================================
- Hits 22154 21358 -796
+ Misses 24738 23389 -1349 ☔ View full report in Codecov by Sentry. |
jedel1043
approved these changes
Mar 29, 2024
nekevss
approved these changes
Mar 29, 2024
Huh, I think there's an error on the modified yaml file.
|
Fixed the workflow but the boa_tester crate needs updating to not try and commit the results. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relies on boa-dev/boa-dev.github.io#145 being merged first.
Essentially this stops adding test262 data to the gh-pages branch on each push to main.
Instead we will rely on the nightly which runs from the data repo instead, this will help remove a lot of data from this repository