Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more utility traits and funtions to boa_interop #3773

Merged
merged 14 commits into from
Apr 9, 2024

use from_copy_closure and remove unsafe

deda29b
Select commit
Loading
Failed to load commit list.
Merged

Add more utility traits and funtions to boa_interop #3773

use from_copy_closure and remove unsafe
deda29b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 9, 2024 in 1s

50.30% (+3.05%) compared to 6ddc2b4

View this Pull Request on Codecov

50.30% (+3.05%) compared to 6ddc2b4

Details

Codecov Report

Attention: Patch coverage is 29.54545% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 50.30%. Comparing base (6ddc2b4) to head (deda29b).
Report is 126 commits behind head on main.

Files Patch % Lines
core/interop/src/lib.rs 23.07% 30 Missing ⚠️
core/interop/src/into_js_function_impls.rs 31.70% 28 Missing ⚠️
core/engine/src/try_into_js_result_impls.rs 50.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3773      +/-   ##
==========================================
+ Coverage   47.24%   50.30%   +3.05%     
==========================================
  Files         476      458      -18     
  Lines       46892    44905    -1987     
==========================================
+ Hits        22154    22589     +435     
+ Misses      24738    22316    -2422     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.