Close for-of iterator when the loop body throws #3734
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the iterator used in a for-of loop is not closed when the loop body throws. This PR fixes that by widening the scope of an exception handler that was already in place for some of the for-of assignment code paths.
To make this work I had to adjust the iterator close opcodes somewhat. The reason is that we may run into a situation when we attempt to close an iterator two times. See the following example:
In this example we close the iterator when we
return
fromf
inside of the loop body. The iterator close code is injected during the compilation of thereturn
statement. The problem is that if theiterable.return
function throws, like in the example, we start running the exception handler code that also attempts to close the iterator. To avoid this I adjusted the iterator close opcodes.