-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a catch all for other categories not labelled #3703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comment this looks good to me! :)
.github/release.yml
Outdated
- Internal | ||
- title: Memory Optimizations | ||
labels: | ||
- memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Internal | |
- title: Memory Optimizations | |
labels: | |
- memory | |
- Internal | |
- memory |
Can't it be added into as a internal improvement, instead of separate section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry I thought you meant you wanted it as a section, my bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 On second thought maybe we should just remove the memory label here, and add Internal where needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't hurt to add it to the internal improvements section, ill put it there for now and if we don't use it its not a big deal. We may want to categorise some things as memory in future
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3703 +/- ##
==========================================
+ Coverage 47.24% 47.66% +0.42%
==========================================
Files 476 454 -22
Lines 46892 44570 -2322
==========================================
- Hits 22154 21245 -909
+ Misses 24738 23325 -1413 ☔ View full report in Codecov by Sentry. |
Add a catch all for other categories not labelled