Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to temporal_rs crate #3694

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Migrate to temporal_rs crate #3694

merged 2 commits into from
Feb 27, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Feb 26, 2024

This Pull Request moves migrates the current implementation over to the new temporal_rs crate.

It changes the following:

  • Removes boa_temporal
  • Adds functionality from temporal_rs

@nekevss nekevss added builtins PRs and Issues related to builtins/intrinsics Internal Category for changelog labels Feb 27, 2024
@nekevss nekevss added this to the v0.18.0 milestone Feb 27, 2024
@nekevss
Copy link
Member Author

nekevss commented Feb 27, 2024

So it looks like there's an infinite loop that's being triggered by one of the Calendar.prototype.dateUntil tests. I've commented out the call to dateUntil and returned an error. I'm going to open an issue in the temporal_rs repo to address the loop.

Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,547 42,565 +18
Ignored 1,570 1,570 0
Failed 6,151 6,133 -18
Panics 0 0 0
Conformance 84.64% 84.68% +0.04%
Fixed tests (19):
test/built-ins/Temporal/Calendar/prototype/dateAdd/overflow-undefined.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/add-months-weeks.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/overflow-wrong-type.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/add-days.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/add-weeks-days.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/add-years-months.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/add-weeks.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/duration-argument-string-negative-fractional-units.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/add-years.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/add-months.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/add-years-weeks.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-plaindatetime.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/options-object.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/add-years-months-days.js (previously Failed)
test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-string-calendar-annotation.js (previously Failed)
Broken tests (1):
test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-string-with-utc-designator.js (previously Passed)

@nekevss nekevss added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 5ce93b2 Feb 27, 2024
13 checks passed
@nekevss nekevss deleted the temporalrs-migration branch February 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants