Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ICU4X data generation from boa_icu_provider #3682

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Feb 19, 2024

Thankss to #3681 I realized we could benefit from isolating our datagen dependencies from boa_icu_provider, which is why I decided to create a separate crate to run the datagen step.

This PR also adds a new flag to exclude the data from boa_engine if the user wants to.

Size comparison

Main

❯ ls -l core/icu_provider/data/icudata.postcard
❯ -rw-r--r-- 1 jedel users 16910774 Feb 18 22:05 core/icu_provider/data/icudata.postcard

PR

❯ ls -l core/icu_provider/data/icudata.postcard
❯ -rw-r--r-- 1 jedel users 16417284 Feb 19 00:29 core/icu_provider/data/icudata.postcard

@jedel1043 jedel1043 added dependencies Pull requests that update a dependency file builtins PRs and Issues related to builtins/intrinsics labels Feb 19, 2024
@jedel1043 jedel1043 added this to the v0.18.0 milestone Feb 19, 2024
@jedel1043 jedel1043 requested a review from a team February 19, 2024 04:12
Copy link

github-actions bot commented Feb 19, 2024

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,565 42,565 0
Ignored 1,570 1,570 0
Failed 6,133 6,133 0
Panics 0 0 0
Conformance 84.68% 84.68% 0.00%

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment below this looks good to me!

core/engine/Cargo.toml Outdated Show resolved Hide resolved
@jedel1043 jedel1043 requested review from a team and HalidOdat February 22, 2024 04:54
@raskad
Copy link
Member

raskad commented Feb 22, 2024

In the latest commit you removed the intl_core feature but did not revert the cfg annotations from intl_core to intl. I think that is why all intl tests are failing on the latest commit right? @jedel1043

@jedel1043
Copy link
Member Author

Yep, yesterday I pushed my changes without checking CI because I was a bit sleepy. Will fix the tests when I have the time.

@raskad raskad requested a review from a team February 24, 2024 00:37
@jedel1043 jedel1043 added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit d346bf8 Feb 27, 2024
14 checks passed
@jedel1043 jedel1043 deleted the split-icu-datagen branch February 27, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants