-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split ICU4X data generation from boa_icu_provider
#3682
Conversation
Test262 conformance changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comment below this looks good to me!
In the latest commit you removed the |
Yep, yesterday I pushed my changes without checking CI because I was a bit sleepy. Will fix the tests when I have the time. |
7212e7f
to
1207095
Compare
Thankss to #3681 I realized we could benefit from isolating our datagen dependencies from
boa_icu_provider
, which is why I decided to create a separate crate to run the datagen step.This PR also adds a new flag to exclude the data from
boa_engine
if the user wants to.Size comparison
Main
PR