Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve .exe suffix for Windows releases #3680

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Feb 18, 2024

In the release workflow we don't add the .exe suffix for Windows builds, since Windows primarily looks at the extension of the file to know what the file is.

In the release workflow we did add the `.exe` suffix for Windows builds, since Windows primarily looks at the extension of the file to know what the file is.
@HalidOdat HalidOdat added the bug Something isn't working label Feb 18, 2024
@HalidOdat HalidOdat added this to the v0.18.0 milestone Feb 18, 2024
@HalidOdat HalidOdat requested a review from a team February 18, 2024 14:21
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,549 42,549 0
Ignored 1,570 1,570 0
Failed 6,149 6,149 0
Panics 0 0 0
Conformance 84.64% 84.64% 0.00%

@raskad raskad added this pull request to the merge queue Feb 18, 2024
Merged via the queue into main with commit 318aa92 Feb 18, 2024
13 checks passed
@HalidOdat HalidOdat deleted the fix/preserve-windows-exe-suffix branch February 18, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants