Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stage 3 feature "arraybuffer-transfer" #3649

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Implement stage 3 feature "arraybuffer-transfer" #3649

merged 1 commit into from
Feb 2, 2024

Conversation

jedel1043
Copy link
Member

This implements the stage 3 proposal ArrayBuffer.prototype.transfer and friends behind our experimental flag. This also puts our ArrayBuffer suite at 100% conformance 🎉

@jedel1043 jedel1043 requested a review from a team February 2, 2024 08:43
@jedel1043 jedel1043 added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Feb 2, 2024
@jedel1043 jedel1043 added this to the v0.18.0 milestone Feb 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

Test262 conformance changes

Test result main count PR count difference
Total 96,310 96,422 +112
Passed 80,819 80,939 +120
Ignored 3,681 3,567 -114
Failed 11,810 11,916 +106
Panics 0 0 0
Conformance 83.92% 83.94% +0.03%
Fixed tests (114): 
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/extensible.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/extensible.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/this-is-detached.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/this-is-detached.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-resizable-to-zero.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-resizable-to-zero.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-resizable-to-smaller.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-resizable-to-smaller.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-resizable-to-same.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-resizable-to-same.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/new-length-non-number.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/new-length-non-number.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-smaller.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-smaller.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/this-is-not-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/this-is-not-object.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-larger.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-larger.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-resizable-to-larger.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-resizable-to-larger.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/descriptor.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/descriptor.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/name.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/name.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-larger-no-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-larger-no-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-same-no-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-same-no-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-same.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-same.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/new-length-excessive.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/new-length-excessive.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/this-is-not-arraybuffer-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/this-is-not-arraybuffer-object.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/length.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/length.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-zero.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-zero.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/this-is-sharedarraybuffer.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/this-is-sharedarraybuffer.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-smaller-no-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-smaller-no-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/nonconstructor.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/nonconstructor.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-zero-no-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transferToFixedLength/from-fixed-to-zero-no-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/extensible.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/extensible.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/this-is-detached.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/this-is-detached.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-zero.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-zero.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-smaller.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-smaller.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-same.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-same.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/new-length-non-number.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/new-length-non-number.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-smaller.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-smaller.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/this-is-not-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/this-is-not-object.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-larger.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-larger.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-larger.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-resizable-to-larger.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/descriptor.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/descriptor.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/name.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/name.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-larger-no-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-larger-no-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-same-no-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-same-no-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-same.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-same.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/new-length-excessive.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/new-length-excessive.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/this-is-not-arraybuffer-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/this-is-not-arraybuffer-object.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/length.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/length.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-zero.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-zero.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/this-is-sharedarraybuffer.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/this-is-sharedarraybuffer.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-smaller-no-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-smaller-no-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/nonconstructor.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/nonconstructor.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-zero-no-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/transfer/from-fixed-to-zero-no-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/invoked-as-func.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/invoked-as-func.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/this-is-not-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/this-is-not-object.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/detached-buffer-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/detached-buffer-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/invoked-as-accessor.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/invoked-as-accessor.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/detached-buffer.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/detached-buffer.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/prop-desc.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/prop-desc.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/this-has-no-arraybufferdata-internal.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/this-has-no-arraybufferdata-internal.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/name.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/name.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/length.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/length.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/this-is-sharedarraybuffer-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/this-is-sharedarraybuffer-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/this-is-sharedarraybuffer.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/detached/this-is-sharedarraybuffer.js (previously Ignored)

HalidOdat
HalidOdat approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat requested a review from a team February 2, 2024 10:09
nekevss
nekevss approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nekevss nekevss added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 76e2b7c Feb 2, 2024
13 checks passed
@jedel1043 jedel1043 deleted the arraybuffer-transfer branch February 2, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @HalidOdat @nekevss