-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove double indirection in module types #3640
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3640 +/- ##
==========================================
+ Coverage 47.27% 47.30% +0.02%
==========================================
Files 476 476
Lines 46798 46834 +36
==========================================
+ Hits 22123 22153 +30
- Misses 24675 24681 +6 ☔ View full report in Codecov by Sentry. |
Test262 conformance changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! Looks good to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Should improve cache locality + allows allocating the whole
Module
struct in a single Gc.