Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests results upload #3635

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Fix tests results upload #3635

merged 3 commits into from
Jan 30, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Jan 30, 2024

Since the 262 tests action now takes a bit longer we had multiple cases where the git push to the gh-pages branch on main did not work because the pulled gh-pages branch was outdated.

This PR attempts to solve this by moving the checkout action for the gh-pages branch after the running of the tests. In most cases this should solve the issue.

@raskad raskad added the github_actions Pull requests that update Github_actions code label Jan 30, 2024
@raskad raskad added this to the v0.18.0 milestone Jan 30, 2024
@raskad raskad requested a review from a team January 30, 2024 18:37
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34d0084) 47.43% compared to head (ce4ec96) 47.41%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3635      +/-   ##
==========================================
- Coverage   47.43%   47.41%   -0.03%     
==========================================
  Files         476      476              
  Lines       46288    46303      +15     
==========================================
- Hits        21959    21955       -4     
- Misses      24329    24348      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test262 conformance changes

Test result main count PR count difference
Total 96,310 96,310 0
Passed 79,712 79,712 0
Ignored 4,217 4,217 0
Failed 12,381 12,381 0
Panics 0 0 0
Conformance 82.77% 82.77% 0.00%

@nekevss nekevss added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit b789ddf Jan 30, 2024
14 checks passed
@jedel1043 jedel1043 deleted the actions-fix-test-results-push branch January 30, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants