Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement resizable buffers #3634

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Implement resizable buffers #3634

merged 1 commit into from
Feb 1, 2024

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Jan 30, 2024 •
edited
Loading

A bit of a complex implementation, but happy with the new design overall. Open for suggestions though!

This implements:

  • Resizable array buffers.
    • Allows ArrayBuffer to resize, but it's limited to a maxByteLength parameter passed at construction time.
    • Allows SharedArrayBuffer to grow (shrinking is disallowed by the spec), also limited to a maxByteLength parameter.
      It uses an AtomicUsize to track the current length, which should be enough to ensure thread-safety.
  • Retrofits Atomics, TypedArray and DataView to use the new buffers.
  • Makes memmove, memcpy and copy_shared_to_shared more low level, computing using pointers.
    The previous design used slices to do debug assertions before copying memory, but this made the API a bit clunkier to use, and some of the assertions weren't even needed by some callers.

EDIT: Forgot to mention that this doesn't add methods to resize JsArrayBuffer and JsSharedArrayBuffer, but this can be added later after some design work.

@jedel1043 jedel1043 added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Jan 30, 2024
@jedel1043 jedel1043 added this to the v0.18.0 milestone Jan 30, 2024
@jedel1043 jedel1043 requested a review from a team January 30, 2024 18:22
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 465 lines in your changes are missing coverage. Please review.

Comparison is base (20dba13) 47.41% compared to head (4abc87a) 47.49%.

Files Patch % Lines
core/engine/src/builtins/array_buffer/mod.rs 16.66% 115 Missing ⚠️
core/engine/src/builtins/array_buffer/shared.rs 16.83% 84 Missing ⚠️
core/engine/src/builtins/typed_array/object.rs 0.00% 75 Missing ⚠️
core/engine/src/builtins/atomics/mod.rs 0.00% 64 Missing ⚠️
core/engine/src/builtins/dataview/mod.rs 0.00% 62 Missing ⚠️
core/engine/src/builtins/array_buffer/utils.rs 0.00% 28 Missing ⚠️
core/engine/src/object/builtins/jsdataview.rs 0.00% 26 Missing ⚠️
core/engine/src/builtins/array/array_iterator.rs 0.00% 3 Missing ⚠️
core/engine/src/object/builtins/jsarraybuffer.rs 0.00% 3 Missing ⚠️
core/engine/src/builtins/atomics/futex.rs 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3634      +/-   ##
==========================================
+ Coverage   47.41%   47.49%   +0.07%     
==========================================
  Files         476      476              
  Lines       46303    46288      -15     
==========================================
+ Hits        21955    21984      +29     
+ Misses      24348    24304      -44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 96,310 96,310 0
Passed 79,712 80,245 +533
Ignored 4,217 3,681 -536
Failed 12,381 12,384 +3
Panics 0 0 0
Conformance 82.77% 83.32% +0.55%
Fixed tests (533): 
test/built-ins/ArrayBuffer/options-maxbytelength-diminuitive.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-diminuitive.js (previously Ignored)
test/built-ins/ArrayBuffer/options-non-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/options-non-object.js (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-object.js (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-negative.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-negative.js (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-excessive.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-excessive.js (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-undefined.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-undefined.js (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-poisoned.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/options-maxbytelength-poisoned.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/extensible.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/extensible.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/this-is-detached.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/this-is-detached.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-same-size-zero-explicit.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-same-size-zero-explicit.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/new-length-non-number.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/new-length-non-number.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-shrink-zero-explicit.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-shrink-zero-explicit.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/this-is-not-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/this-is-not-object.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/descriptor.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/descriptor.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-shrink.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-shrink.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/name.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/name.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-same-size.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-same-size.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-same-size-zero-implicit.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-same-size-zero-implicit.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-grow.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-grow.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-shrink-zero-implicit.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/resize-shrink-zero-implicit.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/this-is-not-resizable-arraybuffer-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/this-is-not-resizable-arraybuffer-object.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/new-length-excessive.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/new-length-excessive.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/this-is-not-arraybuffer-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/this-is-not-arraybuffer-object.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/length.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/length.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/new-length-negative.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/new-length-negative.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/this-is-sharedarraybuffer.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/this-is-sharedarraybuffer.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/nonconstructor.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resize/nonconstructor.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/invoked-as-func.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/invoked-as-func.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/return-maxbytelength-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/return-maxbytelength-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/this-is-not-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/this-is-not-object.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/invoked-as-accessor.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/invoked-as-accessor.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/detached-buffer.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/detached-buffer.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/return-maxbytelength-non-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/return-maxbytelength-non-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/prop-desc.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/prop-desc.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/this-has-no-arraybufferdata-internal.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/this-has-no-arraybufferdata-internal.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/name.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/name.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/length.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/length.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/this-is-sharedarraybuffer.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/maxByteLength/this-is-sharedarraybuffer.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/invoked-as-func.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/invoked-as-func.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/return-resizable.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/return-resizable.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/this-is-not-object.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/this-is-not-object.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/invoked-as-accessor.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/invoked-as-accessor.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/detached-buffer.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/detached-buffer.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/prop-desc.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/prop-desc.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/this-has-no-arraybufferdata-internal.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/this-has-no-arraybufferdata-internal.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/name.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/name.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/length.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/length.js (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/this-is-sharedarraybuffer.js [strict mode] (previously Ignored)
test/built-ins/ArrayBuffer/prototype/resizable/this-is-sharedarraybuffer.js (previously Ignored)
test/built-ins/TypedArray/prototype/indexOf/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/indexOf/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/indexOf/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/indexOf/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/findIndex/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/findIndex/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/findIndex/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/findIndex/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/findIndex/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/findIndex/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/toLocaleString/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toLocaleString/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/toLocaleString/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/toLocaleString/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/includes/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/includes/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/includes/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/includes/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/findLast/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/findLast/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/findLast/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/findLast/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/findLast/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/findLast/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/slice/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/slice/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js (previously Ignored)
test/built-ins/TypedArray/prototype/slice/speciesctor-destination-resizable.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/slice/speciesctor-destination-resizable.js (previously Ignored)
test/built-ins/TypedArray/prototype/slice/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/slice/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/slice/BigInt/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/slice/BigInt/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js (previously Ignored)
test/built-ins/TypedArray/prototype/slice/BigInt/speciesctor-destination-resizable.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/slice/BigInt/speciesctor-destination-resizable.js (previously Ignored)
test/built-ins/TypedArray/prototype/slice/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/slice/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/join/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/join/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/join/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/join/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/reduceRight/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/reduceRight/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/reduceRight/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/reduceRight/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/reduceRight/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/reduceRight/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/keys/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/keys/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/keys/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/keys/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/byteOffset/resizable-array-buffer-fixed.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/byteOffset/resizable-array-buffer-fixed.js (previously Ignored)
test/built-ins/TypedArray/prototype/byteOffset/resizable-array-buffer-auto.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/byteOffset/resizable-array-buffer-auto.js (previously Ignored)
test/built-ins/TypedArray/prototype/byteOffset/BigInt/resizable-array-buffer-fixed.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/byteOffset/BigInt/resizable-array-buffer-fixed.js (previously Ignored)
test/built-ins/TypedArray/prototype/byteOffset/BigInt/resizable-array-buffer-auto.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/byteOffset/BigInt/resizable-array-buffer-auto.js (previously Ignored)
test/built-ins/TypedArray/prototype/lastIndexOf/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/lastIndexOf/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/length/resizable-array-buffer-fixed.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/length/resizable-array-buffer-fixed.js (previously Ignored)
test/built-ins/TypedArray/prototype/length/resizable-array-buffer-auto.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/length/resizable-array-buffer-auto.js (previously Ignored)
test/built-ins/TypedArray/prototype/length/BigInt/resizable-array-buffer-fixed.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/length/BigInt/resizable-array-buffer-fixed.js (previously Ignored)
test/built-ins/TypedArray/prototype/length/BigInt/resizable-array-buffer-auto.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/length/BigInt/resizable-array-buffer-auto.js (previously Ignored)
test/built-ins/TypedArray/prototype/at/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/at/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/at/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/at/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/reduce/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/reduce/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/reduce/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/reduce/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/reduce/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/reduce/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/every/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/every/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/every/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/every/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/every/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/every/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/findLastIndex/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/findLastIndex/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/findLastIndex/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/findLastIndex/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/findLastIndex/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/findLastIndex/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/byteLength/resizable-array-buffer-fixed.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/byteLength/resizable-array-buffer-fixed.js (previously Ignored)
test/built-ins/TypedArray/prototype/byteLength/resizable-array-buffer-auto.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/byteLength/resizable-array-buffer-auto.js (previously Ignored)
test/built-ins/TypedArray/prototype/byteLength/BigInt/resizable-array-buffer-fixed.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/byteLength/BigInt/resizable-array-buffer-fixed.js (previously Ignored)
test/built-ins/TypedArray/prototype/byteLength/BigInt/resizable-array-buffer-auto.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/byteLength/BigInt/resizable-array-buffer-auto.js (previously Ignored)
test/built-ins/TypedArray/prototype/some/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/some/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/some/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/some/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/some/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/some/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/map/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/map/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js (previously Ignored)
test/built-ins/TypedArray/prototype/map/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/map/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/map/speciesctor-destination-resizable.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/map/speciesctor-destination-resizable.js (previously Ignored)
test/built-ins/TypedArray/prototype/map/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/map/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/map/BigInt/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/map/BigInt/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js (previously Ignored)
test/built-ins/TypedArray/prototype/map/BigInt/speciesctor-destination-resizable.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/map/BigInt/speciesctor-destination-resizable.js (previously Ignored)
test/built-ins/TypedArray/prototype/map/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/map/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/reverse/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/reverse/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/reverse/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/reverse/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/filter/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/filter/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js (previously Ignored)
test/built-ins/TypedArray/prototype/filter/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/filter/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/filter/speciesctor-destination-resizable.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/filter/speciesctor-destination-resizable.js (previously Ignored)
test/built-ins/TypedArray/prototype/filter/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/filter/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/filter/BigInt/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/filter/BigInt/speciesctor-get-species-custom-ctor-length-throws-resizable-arraybuffer.js (previously Ignored)
test/built-ins/TypedArray/prototype/filter/BigInt/speciesctor-destination-resizable.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/filter/BigInt/speciesctor-destination-resizable.js (previously Ignored)
test/built-ins/TypedArray/prototype/filter/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/filter/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/sort/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/sort/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/sort/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/sort/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/forEach/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/forEach/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/forEach/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/forEach/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/forEach/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/forEach/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/entries/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/entries/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/entries/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/entries/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/find/callbackfn-resize.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/find/callbackfn-resize.js (previously Ignored)
test/built-ins/TypedArray/prototype/find/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/find/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/find/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/find/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/copyWithin/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/copyWithin/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/copyWithin/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/copyWithin/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/fill/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/fill/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/fill/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/fill/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/values/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/values/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/values/BigInt/return-abrupt-from-this-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/values/BigInt/return-abrupt-from-this-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/set/typedarray-arg-target-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/set/typedarray-arg-target-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/set/typedarray-arg-set-values-same-buffer-same-type-resized.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/set/typedarray-arg-set-values-same-buffer-same-type-resized.js (previously Ignored)
test/built-ins/TypedArray/prototype/set/BigInt/typedarray-arg-target-out-of-bounds.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/set/BigInt/typedarray-arg-target-out-of-bounds.js (previously Ignored)
test/built-ins/TypedArray/prototype/set/BigInt/typedarray-arg-set-values-same-buffer-same-type-resized.js [strict mode] (previously Ignored)
test/built-ins/TypedArray/prototype/set/BigInt/typedarray-arg-set-values-same-buffer-same-type-resized.js (previously Ignored)
test/built-ins/DataView/custom-proto-access-resizes-buffer-invalid-by-length.js [strict mode] (previously Ignored)
test/built-ins/DataView/custom-proto-access-resizes-buffer-invalid-by-length.js (previously Ignored)
test/built-ins/DataView/custom-proto-access-resizes-buffer-valid-by-offset.js [strict mode] (previously Ignored)
test/built-ins/DataView/custom-proto-access-resizes-buffer-valid-by-offset.js (previously Ignored)
test/built-ins/DataView/custom-proto-access-resizes-buffer-invalid-by-offset.js [strict mode] (previously Ignored)
test/built-ins/DataView/custom-proto-access-resizes-buffer-invalid-by-offset.js (previously Ignored)
test/built-ins/DataView/custom-proto-access-resizes-buffer-valid-by-length.js [strict mode] (previously Ignored)
test/built-ins/DataView/custom-proto-access-resizes-buffer-valid-by-length.js (previously Ignored)
test/built-ins/DataView/prototype/setInt16/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/setInt16/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/setBigUint64/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/setBigUint64/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/getUint32/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/getUint32/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/setFloat32/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/setFloat32/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/setInt8/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/setInt8/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/setUint32/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/setUint32/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/getInt8/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/getInt8/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/getUint16/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/getUint16/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/getBigInt64/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/getBigInt64/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/byteOffset/resizable-array-buffer-fixed.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/byteOffset/resizable-array-buffer-fixed.js (previously Ignored)
test/built-ins/DataView/prototype/byteOffset/resizable-array-buffer-auto.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/byteOffset/resizable-array-buffer-auto.js (previously Ignored)
test/built-ins/DataView/prototype/getInt16/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/getInt16/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/setUint8/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/setUint8/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/getInt32/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/getInt32/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/setFloat64/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/setFloat64/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/byteLength/resizable-array-buffer-fixed.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/byteLength/resizable-array-buffer-fixed.js (previously Ignored)
test/built-ins/DataView/prototype/byteLength/resizable-array-buffer-auto.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/byteLength/resizable-array-buffer-auto.js (previously Ignored)
test/built-ins/DataView/prototype/getFloat64/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/getFloat64/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/getUint8/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/getUint8/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/setBigInt64/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/setBigInt64/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/setInt32/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/setInt32/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/getFloat32/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/getFloat32/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/setUint16/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/setUint16/resizable-buffer.js (previously Ignored)
test/built-ins/DataView/prototype/getBigUint64/resizable-buffer.js [strict mode] (previously Ignored)
test/built-ins/DataView/prototype/getBigUint64/resizable-buffer.js (previously Ignored)
test/built-ins/TypedArrayConstructors/ctors/buffer-arg/excessive-offset-throws-resizable-ab.js [strict mode] (previously Ignored)
test/built-ins/TypedArrayConstructors/ctors/buffer-arg/excessive-offset-throws-resizable-ab.js (previously Ignored)
test/built-ins/TypedArrayConstructors/internals/OwnPropertyKeys/integer-indexes-resizable-array-buffer-fixed.js [strict mode] (previously Ignored)
test/built-ins/TypedArrayConstructors/internals/OwnPropertyKeys/integer-indexes-resizable-array-buffer-fixed.js (previously Ignored)
test/built-ins/TypedArrayConstructors/internals/OwnPropertyKeys/integer-indexes-resizable-array-buffer-auto.js [strict mode] (previously Ignored)
test/built-ins/TypedArrayConstructors/internals/OwnPropertyKeys/integer-indexes-resizable-array-buffer-auto.js (previously Ignored)
test/built-ins/TypedArrayConstructors/internals/HasProperty/resizable-array-buffer-fixed.js [strict mode] (previously Ignored)
test/built-ins/TypedArrayConstructors/internals/HasProperty/resizable-array-buffer-fixed.js (previously Ignored)
test/built-ins/TypedArrayConstructors/internals/HasProperty/resizable-array-buffer-auto.js [strict mode] (previously Ignored)
test/built-ins/TypedArrayConstructors/internals/HasProperty/resizable-array-buffer-auto.js (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-diminuitive.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-diminuitive.js (previously Ignored)
test/built-ins/SharedArrayBuffer/options-non-object.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/options-non-object.js (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-object.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-object.js (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-negative.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-negative.js (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-excessive.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-excessive.js (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-undefined.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-undefined.js (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-poisoned.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/options-maxbytelength-poisoned.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/extensible.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/extensible.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/grow-larger-size.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/grow-larger-size.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/new-length-non-number.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/new-length-non-number.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/this-is-not-object.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/this-is-not-object.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/grow-same-size.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/grow-same-size.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/grow-smaller-size.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/grow-smaller-size.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/descriptor.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/descriptor.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/name.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/name.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/this-is-not-resizable-arraybuffer-object.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/this-is-not-resizable-arraybuffer-object.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/new-length-excessive.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/new-length-excessive.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/this-is-not-arraybuffer-object.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/this-is-not-arraybuffer-object.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/length.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/length.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/new-length-negative.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/new-length-negative.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/this-is-sharedarraybuffer.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/this-is-sharedarraybuffer.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/nonconstructor.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/grow/nonconstructor.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/this-is-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/this-is-arraybuffer.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/invoked-as-func.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/invoked-as-func.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/this-is-not-object.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/this-is-not-object.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/invoked-as-accessor.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/invoked-as-accessor.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/prop-desc.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/prop-desc.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/this-has-no-arraybufferdata-internal.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/this-has-no-arraybufferdata-internal.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/return-maxbytelength-non-growable.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/return-maxbytelength-non-growable.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/name.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/name.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/length.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/length.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/return-maxbytelength-growable.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/maxByteLength/return-maxbytelength-growable.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/this-is-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/this-is-arraybuffer.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/invoked-as-func.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/invoked-as-func.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/return-growable.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/return-growable.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/this-is-not-object.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/this-is-not-object.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/invoked-as-accessor.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/invoked-as-accessor.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/prop-desc.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/prop-desc.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/this-has-no-arraybufferdata-internal.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/this-has-no-arraybufferdata-internal.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/name.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/name.js (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/length.js [strict mode] (previously Ignored)
test/built-ins/SharedArrayBuffer/prototype/growable/length.js (previously Ignored)
test/built-ins/Array/prototype/findIndex/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/findIndex/callbackfn-resize-arraybuffer.js (previously Ignored)
test/built-ins/Array/prototype/findLast/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/findLast/callbackfn-resize-arraybuffer.js (previously Ignored)
test/built-ins/Array/prototype/reduceRight/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/reduceRight/callbackfn-resize-arraybuffer.js (previously Ignored)
test/built-ins/Array/prototype/reduce/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/reduce/callbackfn-resize-arraybuffer.js (previously Ignored)
test/built-ins/Array/prototype/every/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/every/callbackfn-resize-arraybuffer.js (previously Ignored)
test/built-ins/Array/prototype/findLastIndex/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/findLastIndex/callbackfn-resize-arraybuffer.js (previously Ignored)
test/built-ins/Array/prototype/some/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/some/callbackfn-resize-arraybuffer.js (previously Ignored)
test/built-ins/Array/prototype/map/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/map/callbackfn-resize-arraybuffer.js (previously Ignored)
test/built-ins/Array/prototype/filter/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/filter/callbackfn-resize-arraybuffer.js (previously Ignored)
test/built-ins/Array/prototype/forEach/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/forEach/callbackfn-resize-arraybuffer.js (previously Ignored)
test/built-ins/Array/prototype/find/callbackfn-resize-arraybuffer.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/find/callbackfn-resize-arraybuffer.js (previously Ignored)
test/staging/ArrayBuffer/resizable/find-last-index-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/subarray-parameter-conversion-shrinks.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/join-parameter-conversion-shrinks.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/find-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/last-index-of-parameter-conversion-grows.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/slice.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/typed-array-length-when-resized-out-of-bounds-1.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/index-of-last-index-of-special-values.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/slice-species-create-resizes.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/map-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/oobbehaves-like-detached.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/length-tracking-1.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/map-species-create-shrinks.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/length-tracking-2.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/for-each-reduce-reduce-right.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/entries-keys-values-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/object-define-property-parameter-conversion-shrinks.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/array-sort-with-default-comparison.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/construct-invalid.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/includes-parameter-conversion-resizes.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/fill-parameter-conversion-resizes.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/find-index-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/array-fill-parameter-conversion-resizes.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/copy-within-parameter-conversion-grows.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/sort-callback-grows.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/typed-array-length-when-resized-out-of-bounds-2.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/subarray.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/object-freeze.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/slice-parameter-conversion-grows.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/iterate-typed-array-and-shrink-to-zero-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/join-parameter-conversion-grows.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/iterate-typed-array.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/test-map.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/for-each-reduce-reduce-right-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/set-with-resizable-source.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/find-index-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/typed-array-prototype.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/find-last-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/find-last-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/reverse.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/some-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/includes.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/sort-callback-shrinks.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/iterate-typed-array-and-grow-just-before-iteration-would-end.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/typed-array-length-and-byte-length.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/object-define-property-parameter-conversion-grows.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/find-last-index-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/map-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/some-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/filter.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/for-each-reduce-reduce-right-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/last-index-of-parameter-conversion-shrinks.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/iterate-typed-array-and-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/set-shrink-target-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/entries-keys-values.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/access-out-of-bounds-typed-array.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/object-define-property-define-properties.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/filter-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/every-some.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/index-of-parameter-conversion-shrinks.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/index-of-last-index-of.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/includes-special-values.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/iterate-typed-array-and-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/find-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/out-of-bounds-typed-array-and-has.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/entries-keys-values-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/function-apply.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/sort-with-custom-comparison.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/subarray-parameter-conversion-grows.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/at.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/construct-from-typed-array.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/copy-within-parameter-conversion-shrinks.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/at-parameter-conversion-resizes.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/index-of-parameter-conversion-grows.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/every-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/destructuring.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/enumerate-elements.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/set-with-resizable-target.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/map-species-create-grows.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/filter-shrink-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/test-fill.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/set-source-length-getter-grows-target.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/set-grow-target-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/every-grow-mid-iteration.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/sort-with-default-comparison.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/test-copy-within.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/find-find-index-find-last-find-last-index.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/set-source-length-getter-shrinks-target.js [strict mode] (previously Ignored)
test/staging/ArrayBuffer/resizable/slice-parameter-conversion-shrinks.js [strict mode] (previously Ignored)

raskad
raskad approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Did you get the chance to run the 262 test suite in debug mode to test all of the debug assertions? Or switch them to asserts for one 262 run maybe.

@raskad raskad requested a review from a team February 1, 2024 01:57
@jedel1043
Copy link
Member Author

Great work!

Did you get the chance to run the 262 test suite in debug mode to test all of the debug assertions? Or switch them to asserts for one 262 run maybe.

Yep, I ran the TypedArray, ArrayBuffer and SharedArrayBuffer suites and I caught some early bugs before opening the PR. I'll do another run of those just in case.

@jedel1043
Copy link
Member Author

Did another run on debug mode and everything looks good!

HalidOdat
HalidOdat approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

@HalidOdat
Copy link
Member

Did another run on debug mode and everything looks good!

We might want to run the test262 tests in release with debug assertions in the CI, might help catch some bugs.

@HalidOdat HalidOdat added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit a9aeaa5 Feb 1, 2024
14 checks passed
@jedel1043 jedel1043 deleted the resizable-buffers branch February 1, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @HalidOdat @raskad