Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements non-erased
JsObject
s akaJsObject<T>
. This allows accessing the inner data of an object without having to calldowncast_ref/mut
every time, which is a big ergonomics win that should avoid callingexpect
a lot of times.This is an MVP that doesn't support calling internal methods using a
JsObject<T>
; adding support for that would require a slight redesign on the API. However, the current MVP is enough to support most of the use cases of the API in our builtin wrappers.This also uses the new API to improve the
JsArrayBuffer
wrapper on some parts, but it still needs some more work that can be done on subsequent PRs.Thanks to @HalidOdat for nerd-sniping me into implementing this 🤣