Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regexp toString method #3608

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix regexp toString method #3608

merged 1 commit into from
Jan 24, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Jan 23, 2024

This Pull Request changes the following:

  • Fix regexp toString method to honor the spec.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics waiting-on-review Waiting on reviews from the maintainers labels Jan 23, 2024
@raskad raskad added this to the v0.18.0 milestone Jan 23, 2024
@raskad raskad requested a review from a team January 23, 2024 22:31
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,588 76,594 +6
Ignored 18,477 18,477 0
Failed 895 889 -6
Panics 0 0 0
Conformance 79.81% 79.82% +0.01%
Fixed tests (6):
test/annexB/built-ins/RegExp/prototype/compile/pattern-string-invalid-u.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-string-invalid-u.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/flags-string-invalid.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/flags-string-invalid.js (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-string-invalid.js [strict mode] (previously Failed)
test/annexB/built-ins/RegExp/prototype/compile/pattern-string-invalid.js (previously Failed)

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0ed7da5) 47.33% compared to head (a1a53aa) 47.36%.
Report is 2 commits behind head on main.

Files Patch % Lines
core/engine/src/builtins/regexp/mod.rs 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3608      +/-   ##
==========================================
+ Coverage   47.33%   47.36%   +0.03%     
==========================================
  Files         475      475              
  Lines       46138    46137       -1     
==========================================
+ Hits        21839    21853      +14     
+ Misses      24299    24284      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@HalidOdat HalidOdat enabled auto-merge January 24, 2024 16:21
@HalidOdat HalidOdat added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 48062d7 Jan 24, 2024
14 checks passed
@raskad raskad deleted the fix-regex-to-string branch January 24, 2024 16:59
@jedel1043 jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants