-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporal Parser Cleanup/Fixes #3521
Conversation
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3521 +/- ##
==========================================
+ Coverage 48.88% 48.98% +0.09%
==========================================
Files 471 471
Lines 48492 48491 -1
==========================================
+ Hits 23705 23751 +46
+ Misses 24787 24740 -47 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
Just some really small nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements!
This PR addresses some of the issues that was causing the parser to panic when running the test suite, along with some general cleanup of the parser.
It changes the following:
FromStr
forMonthDay
andYearMonth
(also removes the ym and dm peeks)Cursor
DateTime
parsing cases to the parser tests fromtest262
.