-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reestructure repo and CI improvements #3505
Conversation
I actually like this change a lot! One early question: is there a reason for |
It's just personal preference, and |
Test262 conformance changes
Fixed tests (4):
Broken tests (2):
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3505 +/- ##
=======================================
Coverage ? 49.01%
=======================================
Files ? 469
Lines ? 48186
Branches ? 0
=======================================
Hits ? 23618
Misses ? 24568
Partials ? 0 ☔ View full report in Codecov by Sentry. |
144295e
to
5549fc8
Compare
41136a1
to
571a724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@@ -10,7 +10,7 @@ | |||
//! | |||
//! [proposal]: https://github.com/tc39/proposal-temporal | |||
//! [spec]: https://tc39.es/proposal-temporal/ | |||
#![doc = include_str!("../../ABOUT.md")] | |||
#![doc = include_str!("../ABOUT.md")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch on this!
Our number of crates is slowly growing, and it's getting harder to find the exact crate that you want to open when working on the repo. This PR proposes:
boa_
prefix on all directories, since that's mostly superfluous.core
for the essential crates.tests
for test crates.ffi
for FFI related crates (only wasm for now).examples
, which is just a plain crate in the root for accessibility.cli
which is just a plain crate for simplicity.This also adds some small CI improvements, like better VSCode launch and task scripts, and some cache actions that weren't caching cargo installs.