Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor vm calling convention to allow locals #3496

Merged
merged 5 commits into from
Dec 20, 2023

Rename ASYNC_GENERATOR_OBJECT_LOCAL_INDEX to ASYNC_GENERATOR_OBJECT_R…

8d41a22
Select commit
Loading
Failed to load commit list.
Merged

Refactor vm calling convention to allow locals #3496

Rename ASYNC_GENERATOR_OBJECT_LOCAL_INDEX to ASYNC_GENERATOR_OBJECT_R…
8d41a22
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2023 in 0s

48.87% (-0.01%) compared to 6ce34c7

View this Pull Request on Codecov

48.87% (-0.01%) compared to 6ce34c7

Details

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (6ce34c7) 48.88% compared to head (8d41a22) 48.87%.

Files Patch % Lines
core/engine/src/vm/opcode/generator/mod.rs 53.33% 7 Missing ⚠️
core/engine/src/vm/mod.rs 73.68% 5 Missing ⚠️
core/engine/src/vm/call_frame/mod.rs 86.20% 4 Missing ⚠️
core/engine/src/vm/opcode/await/mod.rs 50.00% 2 Missing ⚠️
core/engine/src/module/synthetic.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3496      +/-   ##
==========================================
- Coverage   48.88%   48.87%   -0.01%     
==========================================
  Files         471      471              
  Lines       48492    48499       +7     
==========================================
+ Hits        23705    23706       +1     
- Misses      24787    24793       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov