Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent DefVar opcode emit for global binding #3453

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

HalidOdat
Copy link
Member

No description provided.

@HalidOdat HalidOdat added technical debt execution Issues or PRs related to code execution Internal Category for changelog labels Nov 5, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Nov 5, 2023
@HalidOdat HalidOdat requested a review from a team November 5, 2023 15:54
Copy link

github-actions bot commented Nov 5, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 76,518 76,518 0
Ignored 18,132 18,132 0
Failed 959 959 0
Panics 0 0 0
Conformance 80.03% 80.03% 0.00%

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (34d5c51) 44.81% compared to head (64f6e84) 44.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3453      +/-   ##
==========================================
- Coverage   44.81%   44.79%   -0.02%     
==========================================
  Files         488      488              
  Lines       50373    50373              
==========================================
- Hits        22576    22567       -9     
- Misses      27797    27806       +9     
Files Coverage Δ
boa_engine/src/bytecompiler/mod.rs 67.67% <33.33%> (-0.37%) ⬇️
boa_engine/src/vm/opcode/define/mod.rs 33.33% <0.00%> (-9.53%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 added this pull request to the merge queue Nov 5, 2023
Merged via the queue into main with commit 1e90f56 Nov 5, 2023
14 checks passed
ahaoboy pushed a commit to ahaoboy/boa that referenced this pull request Nov 15, 2023
ahaoboy pushed a commit to ahaoboy/boa that referenced this pull request Nov 15, 2023
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
@raskad raskad deleted the prevent-defvar-opcode-generation branch December 5, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution Internal Category for changelog technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants