-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ordinary function [[ConstructorKind]]
to CodeBlock
#3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
technical debt
execution
Issues or PRs related to code execution
Internal
Category for changelog
labels
Oct 30, 2023
HalidOdat
force-pushed
the
refactor/move-constructor-kind-to-codeblock
branch
from
October 30, 2023 09:27
eaa7d8e
to
4e9236f
Compare
Test262 conformance changes
|
HalidOdat
force-pushed
the
refactor/move-constructor-kind-to-codeblock
branch
from
October 30, 2023 09:39
4e9236f
to
5508af0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3439 +/- ##
==========================================
- Coverage 45.40% 45.39% -0.02%
==========================================
Files 483 483
Lines 49790 49787 -3
==========================================
- Hits 22609 22602 -7
- Misses 27181 27185 +4
☔ View full report in Codecov by Sentry. |
HalidOdat
force-pushed
the
refactor/move-constructor-kind-to-codeblock
branch
from
October 30, 2023 09:53
5508af0
to
67ad875
Compare
raskad
approved these changes
Oct 30, 2023
nekevss
approved these changes
Oct 30, 2023
ahaoboy
pushed a commit
to ahaoboy/boa
that referenced
this pull request
Nov 15, 2023
ahaoboy
pushed a commit
to ahaoboy/boa
that referenced
this pull request
Nov 15, 2023
sam-finch-tezos
pushed a commit
to trilitech/boa
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
[[ConstructorKind]]
is known at compile time and it doesn't change, this moves it toCodeBlock
in theCodeBlockFlags
bitflags.