Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix await flag in class constructor #3388

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

raskad
Copy link
Member

@raskad raskad commented Oct 16, 2023

This Pull Request changes the following:

  • Fix await flag in class constructor

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Oct 16, 2023
@raskad raskad added this to the v0.18.0 milestone Oct 16, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 75,687 75,689 +2
Ignored 19,160 19,160 0
Failed 762 760 -2
Panics 0 0 0
Conformance 79.16% 79.17% +0.00%
Fixed tests (2):
test/language/expressions/class/static-init-await-reference.js [strict mode] (previously Failed)
test/language/expressions/class/static-init-await-reference.js (previously Failed)

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dd05f53) 45.72% compared to head (536f76f) 45.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3388      +/-   ##
==========================================
- Coverage   45.72%   45.71%   -0.01%     
==========================================
  Files         482      482              
  Lines       49177    49174       -3     
==========================================
- Hits        22485    22482       -3     
  Misses      26692    26692              
Files Coverage Δ
.../statement/declaration/hoistable/class_decl/mod.rs 50.33% <100.00%> (-0.20%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 requested a review from a team October 16, 2023 02:34
@HalidOdat HalidOdat added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 9bb3bea Oct 16, 2023
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
@raskad raskad deleted the class-constructor-await-fix branch December 5, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants