Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent test262 repository update if not needed #3386

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Conversation

HalidOdat
Copy link
Member

The previous implementation of clone_test262() was fetching the test262 repository on every run even if the commit did not change.

This also removes documentation section about test262 submodule.

This also removes documentation section about `test262` submodule.
@HalidOdat HalidOdat added enhancement New feature or request test Issues and PRs related to the tests. labels Oct 15, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Oct 15, 2023
@HalidOdat HalidOdat requested a review from a team October 15, 2023 08:17
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,342 75,342 0
Ignored 19,482 19,482 0
Failed 750 750 0
Panics 0 0 0
Conformance 78.83% 78.83% 0.00%

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (3177540) 45.86% compared to head (31ba0cd) 45.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3386      +/-   ##
==========================================
- Coverage   45.86%   45.86%   -0.01%     
==========================================
  Files         477      477              
  Lines       48944    48950       +6     
==========================================
  Hits        22450    22450              
- Misses      26494    26500       +6     
Files Coverage Δ
boa_tester/src/main.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raskad raskad added this pull request to the merge queue Oct 15, 2023
Merged via the queue into main with commit 66c2bf4 Oct 15, 2023
@HalidOdat HalidOdat deleted the prevent-fetch-test262 branch October 15, 2023 13:29
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
This also removes documentation section about `test262` submodule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants