-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regular expression construction #3338
Conversation
Test262 conformance changes
|
The previous implementation regular expression (e.g. /abc/) used the global `RegExp`, which caused errors when the `RegExp` was overwritten.
c160e0b
to
b7a16aa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3338 +/- ##
==========================================
+ Coverage 49.42% 49.45% +0.03%
==========================================
Files 445 446 +1
Lines 43891 43948 +57
==========================================
+ Hits 21691 21733 +42
- Misses 22200 22215 +15
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! Some small nitpicks that don't block merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 😄
The previous implementation used the global
RegExp
, which caused errors when theRegExp
was overwritten.