-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused class environments #3332
Conversation
Test262 conformance changes
|
@HalidOdat let me know if you want to have #3322 merge before this, since the changes will cause some conflicts. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3332 +/- ##
==========================================
+ Coverage 49.43% 49.51% +0.08%
==========================================
Files 446 446
Lines 43873 43777 -96
==========================================
- Hits 21688 21678 -10
+ Misses 22185 22099 -86
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor!
As for the merging, I think either way seems fine :)
40aa140
to
6149ec2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Opted for merging the other PR first because this seems like a simpler rebase.
6149ec2
to
265a4c9
Compare
Building on #3328 this removes a bunch of unneeded class environments that where more of a hack to get the class name binding in some places. This also enables removing the
class_object
fromFunctionKind
.